Skip to content

Topic/v4.0.x/from pr7190 7192 #7291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 13, 2020
Merged

Topic/v4.0.x/from pr7190 7192 #7291

merged 2 commits into from
Jan 13, 2020

Conversation

@gpaulsen
Copy link
Member

@gpaulsen gpaulsen commented Jan 8, 2020

Fix spelling mistakes in comments.

@gpaulsen gpaulsen requested a review from hppritcha January 8, 2020 20:31
@gpaulsen gpaulsen added this to the v4.0.3 milestone Jan 8, 2020
gvallee added 2 commits January 8, 2020 15:48
@gvallee @gpaulsen
Fix a type in comments: insertted -> inserted
d59faea 
Signed-off-by: Geoffroy Vallee <geoffroy.vallee@gmail.com>
(cherry picked from commit 98de17c)
Signed-off-by: Geoffrey Paulsen <gpaulsen@us.ibm.com>
@gvallee @gpaulsen
Fix typo in comment: contiaing -> containing
836ce83 
Signed-off-by: Geoffroy Vallee <geoffroy.vallee@gmail.com>
(cherry picked from commit 127573c)
Signed-off-by: Geoffrey Paulsen <gpaulsen@us.ibm.com>
@gpaulsen
Copy link
Member Author

gpaulsen commented Jan 9, 2020

bot:ompi:retest

3 similar comments
@hppritcha
Copy link
Member

hppritcha commented Jan 9, 2020

bot:ompi:retest

@hppritcha
Copy link
Member

hppritcha commented Jan 10, 2020

bot:ompi:retest

@hppritcha
Copy link
Member

hppritcha commented Jan 12, 2020

bot:ompi:retest

@hppritcha
Copy link
Member

hppritcha commented Jan 13, 2020

bot:ompi:retest

not sure what's going on. output from autogen.pl looks different from when I run by hand on same file system at cori.

@gpaulsen
Copy link
Member Author

gpaulsen commented Jan 13, 2020

@hppritcha uh... that's weird. Do we need to diagnose before we create v4.0.3rc1 ? How different is it?

@gpaulsen gpaulsen merged commit 6985a55 into open-mpi:v4.0.x Jan 13, 2020
@gpaulsen gpaulsen deleted the topic/v4.0.x/from_pr7190_7192 branch January 13, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hppritcha hppritcha hppritcha approved these changes

Assignees

No one assigned

Labels

Target: v4.0.x

Projects

None yet

Milestone

v4.0.3

Development

Successfully merging this pull request may close these issues.

3 participants

@gpaulsen @hppritcha @gvallee