configury: allow multiple "-include <file>" options #9131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks LiuFuPin for reporting this issue. Refs. open-mpi#9129 Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
ggouaillardet
force-pushed
the
topic/multiple_include
branch
from
cefbf28 to
a4d3627
Compare
jsquyres
reviewed
Jul 9, 2021
| opal_found=0 | ||
| opal_i=`expr $opal_count + 1` | ||
| ;; | ||
| --include) |
Member
There was a problem hiding this comment.
Is it --include or -include? #9129 (comment) specifically mentions -include. I also see -include in https://gcc.gnu.org/onlinedocs/gcc-11.1.0/gcc/Option-Summary.html#Option-Summary.
Contributor
Author
There was a problem hiding this comment.
great point, let me double check that
Contributor
Author
There was a problem hiding this comment.
it turns out Open MPI is just fine, and only PMIx has to be modified (to support both --include and -include).
I will try to figure out where the difference in behavior comes from ... later.
|
The IBM CI (PGI) build failed! Please review the log, linked below. Gist: https://gist.github.com/1a96bcd4cd8222a858a0b8a401332008 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks LiuFuPin for reporting this issue.
Refs. #9129
Signed-off-by: Gilles Gouaillardet gilles@rist.or.jp