Skip to content

configury: allow multiple "-include <file>" options #9131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

configury: allow multiple "-include <file>" options #9131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions config/opal_functions.m4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ dnl Copyright (c) 2007 Sun Microsystems, Inc. All rights reserved.
dnl Copyright (c) 2009 Oak Ridge National Labs. All rights reserved.
dnl Copyright (c) 2009-2020 Cisco Systems, Inc. All rights reserved.
dnl Copyright (c) 2014 Intel, Inc. All rights reserved.
dnl Copyright (c) 2015-2017 Research Organization for Information Science
dnl and Technology (RIST). All rights reserved.
dnl Copyright (c) 2015-2021 Research Organization for Information Science
dnl and Technology (RIST). All rights reserved.
dnl
dnl $COPYRIGHT$
dnl
Expand Down Expand Up @@ -395,6 +395,10 @@ AC_DEFUN([OPAL_FLAGS_UNIQ],[
opal_found=0
opal_i=`expr $opal_count + 1`
;;
--include)
Copy link
Member

@jsquyres jsquyres Jul 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it --include or -include? #9129 (comment) specifically mentions -include. I also see -include in https://gcc.gnu.org/onlinedocs/gcc-11.1.0/gcc/Option-Summary.html#Option-Summary.

Copy link
Contributor Author

@ggouaillardet ggouaillardet Jul 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great point, let me double check that

Copy link
Contributor Author

@ggouaillardet ggouaillardet Jul 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it turns out Open MPI is just fine, and only PMIx has to be modified (to support both --include and -include).
I will try to figure out where the difference in behavior comes from ... later.

opal_found=0
opal_i=`expr $opal_count + 1`
;;
--param)
opal_found=0
opal_i=`expr $opal_count + 1`
Expand Down