more ompi coverity fixes #950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix CID 1315271: Constant expression result The intent of this conditional is to not produce a peruse event for probe or mprobe requests. Coverity is correct that the expression is always true. Changed the || to && to fix. Also moved the conditional within an OMPI_WANT_PERUSE to ensure the conditional is not evaluated if peruse is disabled. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
Fixes CID 1323841: Logically dead code Wrong value in conditional. Should be newcomp not newcomm. Fixes CID 1269762: Explicit null dereference ompi_group_incl could return an error and not set local_group. Add a check to ensure ompi_group_incl succeeded before incrementing the proc count. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
hjelmn
force-pushed
the
ompi_coverity
branch
from
206ccfe to
6b83fa2
Compare
jsquyres
pushed a commit
to jsquyres/ompi
that referenced
this pull request
Sep 19, 2016
…-opal-fix v1.10: opal.pc.in: fix typo; use the write AC_SUBST'ed variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.