Skip to content

Add Fortran 2008 syntax to the manpages #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2015
Merged

Add Fortran 2008 syntax to the manpages #962

merged 2 commits into from
Oct 13, 2015

Conversation

@ggouaillardet
Copy link
Contributor

@ggouaillardet ggouaillardet commented Oct 1, 2015

Refers #959

@hjelmn
Copy link
Member

hjelmn commented Oct 1, 2015

I see at least one missing one: MPI_Win_shared_query. There might be others. Otherwise 👍.

@hjelmn
Copy link
Member

hjelmn commented Oct 1, 2015

Hmm, sorry. That one is in there. Just didn't show up in the github diff.

I did a quick check and the following files that have f08 were not modified:

MPI_Aint_add.3in
MPI_Wtick.3in (no difference between use mpi and use mpif08 but might be worth showing the use mpif08)
MPI_Wtime.3in (no difference between use mpi and use mpif08 but might be worth showing the use mpif08)

The following were not modified but don't need to be:

MPI_Address (removed MPI-3.0)
MPI_Attr_delete (deprecated)
MPI_Attr_get (deprecated)
MPI_Attr_put (deprecated)
MPI_Comm_f2c (no fortran)
MPI_Errhandler_create (removed MPI-3.0)
MPI_Errhandler_get (removed MPI-3.0)
MPI_Errhandler_set (removed MPI-3.0)
MPI_Keyval_create (deprecated)
MPI_Keyval_free (deprecated)
MPI_Status_f2c (no fortran)
MPI_Type_extent (removed MPI-3.0)
MPI_Type_hindexed (removed MPI-3.0)
MPI_Type_hvector (removed MPI-3.0)
MPI_Type_lb (removed MPI-3.0)
MPI_Type_struct (removed MPI-3.0)
MPI_Type_ub (removed MPI-3.0)

@hjelmn hjelmn added this to the Open MPI v2.0.0 milestone Oct 2, 2015
@jsquyres
Copy link
Member

jsquyres commented Oct 6, 2015

@ggouaillardet Can you have a look at @hjelmn's comment?

@ggouaillardet
Copy link
Contributor Author

ggouaillardet commented Oct 7, 2015

@jsquyres i just pushed my new changes based on @hjelmn comment, and i added an other commit to trim the man pages (if this is not needed, i am fine with that)
btw, this PR has both blocker and enhancement labels (!) i guess blocker is not needed here

@lanl-ompi
Copy link
Contributor

lanl-ompi commented Oct 7, 2015

Test FAILed.

@jsquyres
Copy link
Member

jsquyres commented Oct 7, 2015

I put a blocker label on it because I'd really like to see this stuff in 2.0.0. 😄

@hppritcha There was a failure in the distcheck jenkins -- it complains about make_manpage.pl not being found. Is that a real error?

@ggouaillardet
Copy link
Contributor Author

ggouaillardet commented Oct 7, 2015

I likely forgot to add this new script into the distrib,
will fix that tomorrow

@lanl-ompi
Copy link
Contributor

lanl-ompi commented Oct 8, 2015

Test FAILed.

1 similar comment
@lanl-ompi
Copy link
Contributor

lanl-ompi commented Oct 8, 2015

Test FAILed.

@ggouaillardet
Copy link
Contributor Author

ggouaillardet commented Oct 8, 2015

:bot:retest

@lanl-ompi
Copy link
Contributor

lanl-ompi commented Oct 8, 2015

Test FAILed.

jsquyres
jsquyres reviewed Oct 12, 2015
View reviewed changes
Makefile.ompi-rules Outdated
Copy link
Member

@jsquyres jsquyres Oct 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Watch the excess whitespace at the end of the line here.

@jsquyres
Copy link
Member

jsquyres commented Oct 12, 2015

One other minor/meta comment: should we change

INCLUDE 'mpif.h'

to

USE MPI
! or the older form: INCLUDE 'mpif.h'

@lanl-ompi
Copy link
Contributor

lanl-ompi commented Oct 13, 2015

Test FAILed.

@lanl-ompi
Copy link
Contributor

lanl-ompi commented Oct 13, 2015

Test FAILed.

@ggouaillardet
Copy link
Contributor Author

ggouaillardet commented Oct 13, 2015

:bot:retest

@ggouaillardet
Copy link
Contributor Author

ggouaillardet commented Oct 13, 2015

@jsquyres i made the requested change

@lanl-ompi
Copy link
Contributor

lanl-ompi commented Oct 13, 2015

Test FAILed.

@ggouaillardet
Copy link
Contributor Author

ggouaillardet commented Oct 13, 2015

@hppritcha it looks like a local issue
can you please have a look ?

@jsquyres
Copy link
Member

jsquyres commented Oct 13, 2015

👍

@jsquyres
Copy link
Member

jsquyres commented Oct 13, 2015

@ggouaillardet @hppritcha Looks like a local failure in LANL Cray XC.

jsquyres added a commit that referenced this pull request Oct 13, 2015
@jsquyres
Merge pull request #962 from ggouaillardet/topic/f08_manpages
f0741b8 
Add Fortran 2008 syntax to the manpages
@jsquyres jsquyres merged commit f0741b8 into open-mpi:master Oct 13, 2015
jsquyres added a commit to jsquyres/ompi that referenced this pull request Aug 23, 2016
@jsquyres
Merge pull request open-mpi#962 from ggouaillardet/topic/v2.x/sentine…
07ceea4 
…l_fixes

Topic/v2.x/sentinel fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jsquyres jsquyres

Labels

documentation enhancement Severity: blocker

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ggouaillardet @hjelmn @jsquyres @lanl-ompi