mtl-portals4: fix bug in the Portals4 get_peer family #998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Portals4 get_peer family incorrectly cast the ompi_proc_t to ptl_process_t and returned that as the peer. The ptl_process_t is actually found in the endpoint array. This commit fixes the Portals4 get_peer family to return the dereferenced endpoint pointer.
Member
|
@tkordenbrock Once this is merged should it be added to the 2.x add_procs rollup? |
Member
Author
|
@hjelmn - Yes, if there is still time. |
Member
|
@tkordenbrock There is. Looks like the Mellanox Jenkins is having issues today. Can probably just go ahead and merge this once @regrant has had a chance to review. I will then cherry-pick it into the add_procs PR on 2.x. |
regrant
added a commit
that referenced
this pull request
Oct 8, 2015
…oc.cast Looks good to me. mtl-portals4: fix bug in the Portals4 get_peer family
jsquyres
pushed a commit
to jsquyres/ompi
that referenced
this pull request
Aug 23, 2016
btl/vader: various threading fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Portals4 get_peer family incorrectly cast the ompi_proc_t to
ptl_process_t and returned that as the peer. The ptl_process_t is
actually found in the endpoint array. This commit fixes the
Portals4 get_peer family to return the dereferenced endpoint
pointer.
@regrant - please review