Skip to content

Conversation

@lmarte78
Copy link
Contributor

DCV Checker Lambda Function: update the input parameter from DcvCheckRequest to dict

@sciros
Copy link
Collaborator

sciros commented Nov 16, 2024

Hmm.
I think it might be better to "true up" the CAA checker function to accept a domain object (rather than a dict), than it is to have the DCV checker accept a dict in place of a domain object.
It's what we are doing with the Coordinator and the intent is to have model validation happen on function invocation via AWS Powertools integration with Pydantic.
If it's OK I'm going to actually issue a PR with that change instead.

But a big thanks Luca for bringing this inconsistency to our attention.

The AWS Lambda wrapper project is in a bit of a holding pattern while we focus on instead taking a Kubernetes based approach to completion. Be on the lookout for that as well. Once that's looking good we might polish this one some more too.

@birgelee
Copy link
Member

I do second @sciros on my preference to use entirely domain objects on the calls to open_mpic_core functions particularly since this is what Coordinator is currently set up to do.

That said, I supper appreciate @lmarte78 for bringing this to our attention.

@lmarte78
Copy link
Contributor Author

Hi, I agree with you, it's better to use domain objects!
Thank you for your work on the project.
I'm closing the PR.

@lmarte78 lmarte78 closed this Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants