Skip to content

Update Leaflet to 1.9.4; Fix font-size#13

Merged
jechols merged 1 commit intomainfrom
feature/leaflet-1.9.4
Jun 7, 2024
Merged

Update Leaflet to 1.9.4; Fix font-size#13
jechols merged 1 commit intomainfrom
feature/leaflet-1.9.4

Conversation

@techgique
Copy link
Copy Markdown
Member

Leaflet changed their CSS to set font-size of the leaflet-container class to 0.75rem. ONI Bootstrap sets html element's font-size to 10px, so this causes the font-size of the Leaflet map to 7.5px which is unreasonably small. It also shrinks the map size etc as they are set relative to the container's font-size.

Fixed by setting the font-size of #map_container (which gets the leaflet-container class applied by Leaflet) to 12px.

Leaflet changed their CSS to set font-size of the leaflet-container
class to 0.75rem. ONI Bootstrap sets html element's font-size to
10px, so this causes the font-size of the Leaflet map to 7.5px which
is unreasonably small. It also shrinks the map size etc as they are
set relative to the container's font-size.

Fixed by setting the font-size of #map_container (which gets the
leaflet-container class applied by Leaflet) to 12px.
@techgique techgique force-pushed the feature/leaflet-1.9.4 branch from 3a70827 to c03d1f4 Compare June 7, 2024 00:31
Copy link
Copy Markdown
Contributor

@jechols jechols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jechols jechols merged commit 39ff8c0 into main Jun 7, 2024
@jechols jechols deleted the feature/leaflet-1.9.4 branch June 7, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants