Merged
Conversation
stefansc1
commented
Jun 19, 2025
stefansc1
commented
- change ajax calls to fetch
- fix POST body in GET request
- fix HTML replacement for invalid forms
- alert on errors that do not update HTML (e.g. server not reachable)
- fix doubleclick error on empty space in editor (closestNode not set)
- delete static_src files
- better indentation for scenario_step2.html
- changed some sweet alert promises to standard confirm/alert boxes
- add check for empty model and missing nodesToDB entries
- make grid_model_topology file conform to jshint
- fix doubleclick error on empty space (closestNode not set) - change ajax calls to fetch - fix POST body in GET request - fix HTML replacement for invalid forms - alert on errors that do not update HTML (e.g. server not reachable) - delete static_src files - better indentation for scenario_step2.html - changed some sweet alert promises to standard confirm/alert boxes - add check for empty model and missing nodesToDB entries - make grid_model_topology file conform to jshint
- fix doubleclick error on empty space (closestNode not set) - change ajax calls to fetch - fix POST body in GET request - fix HTML replacement for invalid forms - alert on errors that do not update HTML (e.g. server not reachable) - delete static_src files - better indentation for scenario_step2.html - changed some sweet alert promises to standard confirm/alert boxes - add check for empty model and missing nodesToDB entries - make grid_model_topology file conform to jshint
Bachibouzouk
force-pushed
the
refactor/scenario_step2
branch
from
c707c90 to
a16e83c
Compare
| } | ||
| // Check for nodes to in nodesToDB | ||
| // A missing entry usually stems from missing values and blocks creation of drawflowData | ||
| const nodesNotInDB = node_list.filter(node => !nodesToDB.has('node-'+node.id)); |
There was a problem hiding this comment.
If the nodes' form save without error, then the component should simply be saved and only the one with missing parameters should appear on this list (ie a DSO should be able to be dragged and saved via the next or the save button). With the current implementation the user must click through all components and save them individually
Author
There was a problem hiding this comment.
Nodes are now saved when added to editor (after drag-and-drop). It populates the modal (same as with double-click) and submits form. On success, node information is saved, allowing for model save or hitting "Next" without having to go into every single node. On error, modal opens with failed fields highlighted.
added 3 commits
June 25, 2025 09:16
Bachibouzouk
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.