rego: Allow per-eval GenerateJSON function#8690
Merged
anderseknert merged 1 commit intoMay 26, 2026
Merged
Conversation
The Rego API's `GenerateJSON` function allows clients to provide custom logic for transforming an original AST result into whatever format they may need. Previously this could only be set on the Rego object directly, meaning that a single prepared query would have to use the same function for all evaluations. This change adds the option to additionally set an `EvalGenerateJSON function scoped to individual evaluations, making it easier to reuse a single prepared query even when the shape of the result is determined dynamically, by input data, in-policy routing, etc. Signed-off-by: Anders Eknert <anders.eknert@apple.com>
srenatus
approved these changes
May 26, 2026
Comment on lines
+2478
to
+2481
| generateJSON := r.generateJSON | ||
| if ectx.generateJSON != nil { | ||
| generateJSON = ectx.generateJSON | ||
| } |
Contributor
There was a problem hiding this comment.
Same as
generateJSON = cmp.Or(ectx.generateJSON, r.generateJSON)
but it doesn't matter
Member
Author
There was a problem hiding this comment.
Nope, functions are not comparable
Contributor
There was a problem hiding this comment.
Huh! I thought these would be treated as pointers. I see.
| assertResultSet(t, rs, `[["prepare-generate"]]`) | ||
| } | ||
|
|
||
| func generateJSONResult(s string) func(*ast.Term, *EvalContext) (any, error) { |
Contributor
There was a problem hiding this comment.
We could have put it into TestEvalGenerateJSON as a function literal, but it won't hurt anyone here either
Benchmark Regression DetectedCommit
Notable Improvements 🎉Commit
This comment was automatically generated by the benchmarks workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Rego API's
GenerateJSONfunction allows clients to provide custom logic for transforming an original AST result into whatever format they may need. Previously this could only be set on the Rego object directly, meaning that a single prepared query would have to use the same function for all evaluations. This change adds the option to additionally set an `EvalGenerateJSON function scoped to individual evaluations, making it easier to reuse a single prepared query even when the shape of the result is determined dynamically, by input data, in-policy routing, etc.