Fix duplicated enum elements by sorting before emitting

Fix #54 (duplicated enum elements)
by sorting the output of keys() before emitting the elements.

Change-Id: Ib4117ca25c67de3a3d93d220695cc6e76eb4e30f
ForwardPort: yes
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/25015
Tested-by: Jenkins Server
Tested-by: Jenkins OP Build CI
Tested-by: Jenkins OP HW
Tested-by: FSP CI Jenkins
Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
Reviewed-by: Thi N. Tran <thi@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>

Author: deece

src/usr/hwpf/fapi/fapiParseErrorInfo.pl

@@ -7,6 +7,7 @@
 # OpenPOWER HostBoot Project
 #
 # Contributors Listed Below - COPYRIGHT 2011,2016
+# [+] Alastair D'Silva
 # [+] International Business Machines Corp.
 #
 #
@@ -819,7 +820,7 @@ sub setFfdcIdValue
         } # gard
 
         # Process the callout, deconfigures and GARDs for each Target
-        foreach my $cdg (keys %cdgTargetHash)
+        foreach my $cdg (sort keys %cdgTargetHash)
         {
             # Check the type
             print EIFILE "fapi::fapiCheckType<const fapi::Target *>(&$cdg); \\\n";
@@ -860,12 +861,12 @@ sub setFfdcIdValue
         }
 
         # Process the callout, deconfigures and GARDs for Child Targets
-        foreach my $parent (keys %cdgChildHash)
+        foreach my $parent (sort keys %cdgChildHash)
         {
             # Check the type
             print EIFILE "fapi::fapiCheckType<const fapi::Target *>(&$parent); \\\n";
 
-            foreach my $childType (keys %{$cdgChildHash{$parent}})
+            foreach my $childType (sort keys %{$cdgChildHash{$parent}})
             {
                 my $callout = 0;
                 my $priority = 'LOW';
@@ -1174,14 +1175,14 @@ sub setFfdcIdValue
 print RCFILE " *\/\n";
 print RCFILE "enum HwpReturnCode\n";
 print RCFILE "{\n";
-foreach my $key (keys %errNameToValueHash)
+foreach my $key (sort keys %errNameToValueHash)
 {
     print RCFILE "    $key = 0x$errNameToValueHash{$key},\n";
 }
 print RCFILE "};\n\n";
 print RCFILE "}\n\n";
 print RCFILE "#else\n";
-foreach my $key (keys %errNameToValueHash)
+foreach my $key (sort keys %errNameToValueHash)
 {
     print RCFILE "    .set $key, 0x$errNameToValueHash{$key}\n";
 }
@@ -1198,7 +1199,7 @@ sub setFfdcIdValue
 print EIFILE " *\/\n";
 print EIFILE "enum HwpFfdcId\n";
 print EIFILE "{\n";
-foreach my $key (keys %ffdcNameToValueHash)
+foreach my $key (sort keys %ffdcNameToValueHash)
 {
     print EIFILE "    $key = 0x$ffdcNameToValueHash{$key},\n";
 }