Skip to content

Commit ac6bf1e

Browse files
zane131A. Patrick Williams III
authored andcommitted
PRD: Disable garding for checkstops caused by OPAL
Change-Id: Ic062ca7d64a24caeed89bdfed2df58043b3c92c0 Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/19154 Reviewed-by: Caleb N. Palmer <cnpalmer@us.ibm.com> Reviewed-by: BENJAMIN J. WEISENBECK <bweisenb@us.ibm.com> Tested-by: Jenkins Server Reviewed-by: Brian J. Stegmiller <bjs@us.ibm.com> Reviewed-by: A. Patrick Williams III <iawillia@us.ibm.com> Reviewed-by: Zane Shelley <zshelle@us.ibm.com> Reviewed-on: http://gfw160.aus.stglabs.ibm.com:8080/gerrit/19573 Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW
1 parent 1384642 commit ac6bf1e

File tree

1 file changed

+15
-3
lines changed

1 file changed

+15
-3
lines changed

src/usr/diag/prdf/common/framework/service/prdfRasServices_common.C

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -490,11 +490,23 @@ errlHndl_t ErrDataService::GenerateSrcPfa( ATTENTION_TYPE i_attnType,
490490
// software generated the attention. This will be determined if there is a
491491
// software callout with higher priority than a hardware callout.
492492
if ( sappSwNoGardReq && sappHwNoGardReq && // Gard requirements met
493-
isHyprConfigOpal() && isHyprRunning() && // OPAL is running
493+
isHyprConfigOpal() && // OPAL is used
494494
!isMfgAvpEnabled() && !isMfgHdatAvpEnabled() ) // No AVPs running
495495
{
496-
gardErrType = HWAS::GARD_NULL;
497-
prdGardErrType = GardAction::NoGard;
496+
#ifdef __HOSTBOOT_MODULE
497+
// TODO RTC 119791: With the current implementation, we know the
498+
// checkstop occured at runtime if we are doing checkstop analysis.
499+
// Eventually we will add checkstop handling during the IPL. In this
500+
// case, we will need to add a flag to the FIRDATA indicating when the
501+
// FIRDATA was collected.
502+
if ( isHyprRunning() || (MACHINE_CHECK == i_attnType) )
503+
#else
504+
if ( isHyprRunning() )
505+
#endif
506+
{
507+
gardErrType = HWAS::GARD_NULL;
508+
prdGardErrType = GardAction::NoGard;
509+
}
498510
}
499511

500512
for ( SDC_MRU_LIST::const_iterator it = mruList.begin();

0 commit comments

Comments
 (0)