Improve internal data model#608
Merged
Merged
Conversation
- Add jsconfig.json with tsc validation (@/* alias, checkJs per-file) - Install typescript and @types/three as dev dependencies - Split src/types/simulation.js into focused files: building, simulation, vegetation, pvSystem, frontendState, scene - Add FrontendState runtime const (fixes ErrorAdress typo → ErrorAddress) - SimulationResult is now defined as scene-level, not per-building
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal Data Model Refactor
This PR introduces a proper internal data model for the 3D viewer, replacing the loosely-typed structures that were previously passed around.
What changed:
The previous approach used ad-hoc object shapes spread across the codebase, making it hard to refactor or extend the simulation logic. The new type definitions serve as a single source of truth for the data flowing through the viewer.