Skip to content

Fixed The issue with sumatra repeat and diff (only git)#356

Merged
apdavison merged 4 commits intoopen-research:masterfrom
maharjun:DiffRelatedBugFIx
Sep 10, 2017
Merged

Fixed The issue with sumatra repeat and diff (only git)#356
apdavison merged 4 commits intoopen-research:masterfrom
maharjun:DiffRelatedBugFIx

Conversation

@maharjun
Copy link
Copy Markdown
Contributor

This is in reference to issue #354. I have implemented a fix as follows

  1. Added the functions reset and patch to the WorkingCopy Interface and implemented them for git, unfortunately I do not have any experience with the other API's and so I cannot implement them
  2. Updated update_code to take a diff string as an argument and apply diffs
  3. Updated the Record.launch function to take diff as a keyword argument so that diff stored code can also be launched.
  4. Updated the Project.Repeat function to reset the diff along with commit version at the end of run.

@apdavison
Copy link
Copy Markdown
Contributor

apdavison commented Sep 10, 2017

This could do with some tests, but I will implement them as part of extending this to the other version control systems (#365)

@apdavison apdavison merged commit b182773 into open-research:master Sep 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants