Skip to content

Conversation

@shanejonas
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Dec 16, 2019

Codecov Report

Merging #217 into master will increase coverage by 0.3%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #217     +/-   ##
=========================================
+ Coverage   92.28%   92.59%   +0.3%     
=========================================
  Files          16       16             
  Lines         350      351      +1     
  Branches       83       84      +1     
=========================================
+ Hits          323      325      +2     
- Misses         13       14      +1     
+ Partials       14       12      -2
Impacted Files Coverage Δ
src/Errors/Errors.tsx 90.47% <ø> (ø) ⬆️
src/ExamplePairing/ExamplePairing.tsx 91.3% <ø> (-4.35%) ⬇️
src/Info/Info.tsx 100% <ø> (ø) ⬆️
src/Params/Params.tsx 100% <ø> (ø) ⬆️
src/ExpansionTable/ExpansionTable.tsx 100% <ø> (ø) ⬆️
src/Links/Links.tsx 96.15% <ø> (ø) ⬆️
src/Servers/Servers.tsx 95.83% <ø> (ø) ⬆️
src/Methods/Methods.tsx 90.24% <100%> (+2.74%) ⬆️
src/ContentDescriptor/ContentDescriptor.tsx 96% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2eb04e...9ca42c1. Read the comment docs.

@shanejonas shanejonas self-assigned this Dec 16, 2019
zcstarr
zcstarr previously approved these changes Dec 16, 2019
Copy link
Member

@zcstarr zcstarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just a typo to address with the test name.

Co-Authored-By: Zane Starr <zcstarr@gmail.com>
Co-Authored-By: Zane Starr <zcstarr@gmail.com>
@shanejonas shanejonas requested a review from zcstarr December 16, 2019 20:52
Copy link
Member

@zcstarr zcstarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@shanejonas shanejonas merged commit 41ed7d3 into master Dec 16, 2019
@shanejonas shanejonas deleted the fix/add-transition-props-upgrade-react branch December 16, 2019 21:15
@openrpc-bastion
Copy link
Member

🎉 This PR is included in version 1.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants