Skip to content

fix: handle recursive json schema #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 16, 2020
Merged

fix: handle recursive json schema #244

merged 3 commits into from
Jan 16, 2020

Conversation

@shanejonas
Copy link
Member

@shanejonas shanejonas commented Jan 15, 2020 •
edited
Loading

image

@shanejonas shanejonas force-pushed the fix/json-schema-nested-arrays branch 2 times, most recently from 0b29489 to 9ab948d Compare January 16, 2020 00:05
@shanejonas shanejonas self-assigned this Jan 16, 2020
@shanejonas shanejonas added bug Something isn't working enhancement New feature or request labels Jan 16, 2020
@shanejonas shanejonas force-pushed the fix/json-schema-nested-arrays branch from 9ab948d to ca9ce9d Compare January 16, 2020 00:07
@codecov
Copy link

codecov bot commented Jan 16, 2020 •
edited
Loading

Codecov Report

Merging #244 into master will increase coverage by 2.78%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #244      +/-   ##
==========================================
+ Coverage   92.59%   95.37%   +2.78%     
==========================================
  Files          16       16              
  Lines         351      346       -5     
  Branches       84       86       +2     
==========================================
+ Hits          325      330       +5     
+ Misses         14        8       -6     
+ Partials       12        8       -4
Impacted Files Coverage Δ
src/JSONSchema/fields/JSONSchemaFields.tsx 100% <100%> (+13.33%) ⬆️
src/JSONSchema/SchemaRenderer.tsx 100% <100%> (ø)
src/JSONSchema/JSONSchema.tsx 100% <100%> (+12.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41ed7d3...e2fb491. Read the comment docs.

@shanejonas shanejonas merged commit a91cae9 into master Jan 16, 2020
@shanejonas shanejonas deleted the fix/json-schema-nested-arrays branch January 16, 2020 02:08
@openrpc-bastion
Copy link
Member

openrpc-bastion commented Jan 16, 2020

🎉 This PR is included in version 1.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@shanejonas shanejonas mentioned this pull request Jan 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BelfordZ BelfordZ BelfordZ approved these changes

@zcstarr zcstarr Awaiting requested review from zcstarr

Assignees

@shanejonas shanejonas

Labels

bug Something isn't working enhancement New feature or request released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shanejonas @openrpc-bastion @BelfordZ