Skip to content

Conversation

@shanejonas
Copy link
Member

@shanejonas shanejonas commented Apr 1, 2019

fixes #37

Screenshot
image

@shanejonas shanejonas requested a review from BelfordZ April 1, 2019 06:45
@shanejonas shanejonas self-assigned this Apr 1, 2019
@codecov
Copy link

codecov bot commented Apr 1, 2019

Codecov Report

Merging #38 into master will increase coverage by 0.31%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   90.43%   90.74%   +0.31%     
==========================================
  Files          15       16       +1     
  Lines         324      335      +11     
  Branches       67       68       +1     
==========================================
+ Hits          293      304      +11     
  Misses         17       17              
  Partials       14       14
Impacted Files Coverage Δ
src/Methods/Methods.tsx 86.48% <100%> (+0.77%) ⬆️
src/Tags/Tags.tsx 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb64574...7afe61d. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 1, 2019

Codecov Report

Merging #38 into master will increase coverage by 0.36%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #38      +/-   ##
=========================================
+ Coverage   90.43%   90.8%   +0.36%     
=========================================
  Files          15      16       +1     
  Lines         324     337      +13     
  Branches       67      69       +2     
=========================================
+ Hits          293     306      +13     
  Misses         17      17              
  Partials       14      14
Impacted Files Coverage Δ
src/Methods/Methods.tsx 86.48% <100%> (+0.77%) ⬆️
src/Tags/Tags.tsx 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb64574...2114751. Read the comment docs.

<Typography key={method.name} className={classes.heading}>{method.name}</Typography>
<Typography key={method.summary} className={classes.secondaryHeading}>{method.summary}</Typography>
</ExpansionPanelSummary>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@shanejonas shanejonas merged commit d888df2 into master Apr 2, 2019
@shanejonas shanejonas deleted the fix/add-tags branch April 2, 2019 00:39
@shanejonas
Copy link
Member Author

🎉 This PR is included in version 1.0.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add tag support

3 participants