Implemented generateWebsiteScreenshot() in dart using Screeenly API. #63
Conversation
…PI in order to get screenshots. Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>
… README Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>
Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>
|
@Meldiron this PR is ready for review please check it once. |
stnguyen90
left a comment
stnguyen90
left a comment
There was a problem hiding this comment.
Great PR! 🤯 We left some comments during the review, please check them out.
Co-authored-by: Steven <1477010+stnguyen90@users.noreply.github.com>
Co-authored-by: Steven <1477010+stnguyen90@users.noreply.github.com>
Co-authored-by: Steven <1477010+stnguyen90@users.noreply.github.com>
35C4n0r
changed the title
|
@stnguyen90 there was one more minor change, the service used was "screeenly" not "screenly". I have corrected that in all the files. |
|
Thank you so much for the PR 🤩. We're adding the |
stnguyen90
left a comment
stnguyen90
left a comment
There was a problem hiding this comment.
Hopefully, the last request! 😬
|
@stnguyen90 sorry for so many errors in the code, i've made the suggested changes please review them once more. |
stnguyen90
left a comment
stnguyen90
left a comment
There was a problem hiding this comment.
one tiny minor change, but otherwise, it's beautiful! 🤩
Co-authored-by: Steven <1477010+stnguyen90@users.noreply.github.com>
|
THANK YOU! All changes merged 🥳 Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord. You can accept the invite by visiting https://github.com/orgs/appwrite/invitation. By joining our team, you will officially be an Appwrite maintainer on GitHub. You can change your membership visibility settings, so your new Appwrite team membership badge will show up on your personal GitHub profile. Please feel free to look for more PRs you might be interested in helping with on our long list of Hacktoberfest friendly issues and help make Appwrite better :) |
4 participants
Implemented the function mentioned in appwrite/appwrite#4107
Closes appwrite/appwrite#4107
Sample Scareenshots:
Success
Failure (Old Screenshot, a minor change was made in the code 62a062c i'm sure it works fine.)
Signed-off-by: 35C4n0r jaykumar20march@gmail.com