Merged
Conversation
Meldiron
commented
Jul 21, 2024
| @@ -1,6 +1,6 @@ | |||
| OPR_EXECUTOR_ENV=development | |||
| OPR_EXECUTOR_RUNTIMES=php-8.1,dart-2.18,deno-1.24,node-18.0,python-3.10,ruby-3.1,cpp-17,dotnet-6.0 | |||
| OPR_EXECUTOR_CONNECTION_STORAGE=file://localhost | |||
Contributor
Author
There was a problem hiding this comment.
This prevents test warning:
openruntimes-executor | Deprecated: ltrim(): Passing null to parameter #1 ($string) of type string is deprecated in /usr/local/vendor/utopia-php/dsn/src/DSN/DSN.php on line 128
Meldiron
commented
Jul 21, 2024
| LABEL maintainer="team@appwrite.io" | ||
|
|
||
| ENV DOCKER_CONFIG=${DOCKER_CONFIG:-$HOME/.docker} | ||
| ENV DOCKER_API_VERSION=1.44 |
Contributor
Author
There was a problem hiding this comment.
This prevents test error:
Error response from daemon: client version 1.44 is too new. Maximum supported API version is 1.43
Meldiron
commented
Jul 21, 2024
Comment on lines
+1020
to
+1023
| if (!(\str_starts_with($path, '/'))) { | ||
| $path = '/' . $path; | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This is the main fox. Error before:
Internal curl errors has occurred within the executor! Error Number: 3. Error Msg: URL rejected: Port number was not a decimal number between 0 and 65535
christyjacob4
approved these changes
Jul 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.