Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Contributors tab for Repo pages #3342

Merged
merged 11 commits into from
May 14, 2024
Merged

feat: Contributors tab for Repo pages #3342

merged 11 commits into from
May 14, 2024

Conversation

zeucapua
Copy link
Contributor

@zeucapua zeucapua commented May 8, 2024 •
edited
Loading

Description

Adds a /contributors page for repo pages, with a tab list to go between the overview and contributor pages. Uses the Contributors component used in the /explore page.

Related Tickets & Documents

Closes #3334

Mobile & Desktop Screenshots/Recordings

image

Steps to QA

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

@netlify Netlify
Copy link

netlify bot commented May 8, 2024 •
edited
Loading

✅ Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit 435432d
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/6642756b00cf92000862285c
😎 Deploy Preview https://deploy-preview-3342--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented May 8, 2024 •
edited
Loading

✅ Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit 435432d
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/6642756b1594dd000892df17
😎 Deploy Preview https://deploy-preview-3342--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zeucapua zeucapua marked this pull request as ready for review May 8, 2024 18:36
@zeucapua zeucapua requested a review from a team May 8, 2024 18:36
BekahHW
BekahHW requested changes May 8, 2024
View reviewed changes
Copy link
Member

@BekahHW BekahHW left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's something going on when you select more contributors than there are.

image

This is where I'm looking. https://deploy-preview-3342--oss-insights.netlify.app/s/open-sauced/app/contributors?limit=40&range=90

@isabensusan
Copy link
Member

isabensusan commented May 8, 2024 •
edited
Loading

Thank you for this @zeucapua !!

Question: is there a way to filter what we show on the contributor's cards to only display work done for the specific repository on the repo page?

So for example, in the open-sauced/app repo page the contributors card show contribution data for all repos, not just the app repo. I.e. in the screenshow we see the contributor's activity for the app repo but also for the freeCodeCamp repo

Is there a way to limit it to the app repo only?
image

@jpmcb
Copy link
Member

jpmcb commented May 8, 2024

Is there a way to limit it to the app repo only?

Not in the /v2/users/{username}/prs endpoint: I can quick add that though: should be simple enough 👍🏼

@zeucapua
Copy link
Contributor Author

zeucapua commented May 8, 2024

Thank you for this @zeucapua !!

Question: is there a way to filter what we show on the contributor's cards to only display work done for the specific repository on the repo page?

So for example, in the open-sauced/app repo page the contributors card show contribution data for all repos, not just the app repo. I.e. in the screenshow we see the contributor's activity for the app repo but also for the freeCodeCamp repo

Is there a way to limit it to the app repo only?

We can do that. The current component was from the /explore page and therefore isn't specific to repos. I can make a new repo page specific contributors component to do this.

nickytonline
nickytonline requested changes May 8, 2024
View reviewed changes
Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tabs need their the parent div they're container in to have a bottom border, border-b, like the explore page. It's currently not like that in workspace pages, but I've made the same change in my PR.

CleanShot 2024-05-08 at 18 52 10@2x

@zeucapua zeucapua mentioned this pull request May 10, 2024
Open
github-actions[bot]
github-actions bot reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

nickytonline
nickytonline reviewed May 10, 2024
View reviewed changes
Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like a bad merge happened. I see the changelog in the list of files.

CleanShot 2024-05-10 at 11 35 59

@zeucapua zeucapua requested review from BekahHW, nickytonline and a team May 13, 2024 20:22
nickytonline
nickytonline approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

brandonroberts
brandonroberts approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! 🍕

@brandonroberts brandonroberts merged commit f1142c3 into beta May 14, 2024
19 checks passed
@brandonroberts brandonroberts deleted the feat/repo-pages-contributors branch May 14, 2024 14:45
open-sauced bot pushed a commit that referenced this pull request May 14, 2024
@zeucapua @open-sauced
chore(minor): release 2.27.0-beta.4 on beta channel [skip ci]
dd6c4df 
## [2.27.0-beta.4](v2.27.0-beta.3...v2.27.0-beta.4) (2024-05-14)

### 🍕 Features

* Contributors tab for Repo pages ([#3342](#3342)) ([f1142c3](f1142c3))
open-sauced bot pushed a commit that referenced this pull request May 15, 2024
@nickytonline @open-sauced
chore(minor): release 2.27.0 [skip ci]
3110382 
## [2.27.0](v2.26.0...v2.27.0) (2024-05-15)

### 🍕 Features

* Contributors tab for Repo pages ([#3342](#3342)) ([f1142c3](f1142c3))
* Lottery Factor chart for Repo pages ([#3343](#3343)) ([deda50e](deda50e))

### 🐛 Bug Fixes

* now opening workspace dropdown puts focus on search input ([#3364](#3364)) ([bafa0e4](bafa0e4))
* now StarSearch remains visible on smaller screens in the top menu ([#3374](#3374)) ([d6d0048](d6d0048))
* temporarily returning for event: function_call in readable stream from StarSearch ([#3379](#3379)) ([f6f4b01](f6f4b01))
* title for PR chart tooltip ([#3350](#3350)) ([56b2746](56b2746))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@nickytonline nickytonline nickytonline approved these changes

@brandonroberts brandonroberts brandonroberts approved these changes

@BekahHW BekahHW Awaiting requested review from BekahHW

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: add Contributor Tab to Repo Pages
6 participants
@zeucapua @isabensusan @jpmcb @brandonroberts @nickytonline @BekahHW