feat: Adds info on adding teammates to the insights page by Lymah123 · Pull Request #230 · open-sauced/docs

Lymah123 · 2023-12-08T02:07:43Z

Description

This PR adds the feature to the docs in the insights section.

What type of PR is this? (check all applicable)

Related Tickets & Documents

Fixes #202
Add info on adding teammates to insights page

Mobile & Desktop Screenshots/Recordings

Steps to QA

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify · 2023-12-08T02:07:46Z

👷 Deploy request for docs-open pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	`c60631c`

Lymah123 · 2023-12-08T02:15:46Z

Hi @adiati98 , @BekahHW, and @CBID2. I will be waiting for your reviews

adiati98

@Lymah123 I've left some reviews here. :)

@BekahHW we need your thoughts and confirmation on some things here.

TIA!

docs/features/insights.md

Co-authored-by: Ayu Adiati <45172775+adiati98@users.noreply.github.com>

BekahHW

Hey @Lymah123. Thanks for taking this on! I wasn't specific enough in the issue. Take a look at the video in the comments for the two ways to share and let me know if you have questions.

Lymah123 · 2023-12-14T20:50:58Z

Hi @BekahHW and @adiati98, sorry for not being responsive for the past three days on your reviews. I have gone through your feedback. I have started working on them. Thanks for being patient with me. I will soon request for your reviews again .

CBID2 · 2023-12-15T08:34:41Z

Hi @BekahHW and @adiati98, sorry for not being responsive for the past three days on your reviews. I have gone through your feedback. I have started working on them. Thanks for being patient with me. I will soon request for your reviews again .

Hi @Lymah123! There’s some merge conflicts on your branch. Can you solve them please?

Lymah123 · 2023-12-15T11:36:17Z

Hi @BekahHW and @adiati98, sorry for not being responsive for the past three days on your reviews. I have gone through your feedback. I have started working on them. Thanks for being patient with me. I will soon request for your reviews again .

Hi @Lymah123! There’s some merge conflicts on your branch. Can you solve them please?

Hi @CBID2 , I will resolve them. I just saw the conflicts on the PR today.

Lymah123 · 2023-12-16T18:38:06Z

@CBID2 , I have resolved the conflicts.

docs/features/insights.md

CBID2 · 2023-12-17T04:05:25Z

@CBID2 , I have resolved the conflicts.

Just gave some feedback here @Lymah123

adiati98 · 2023-12-28T10:52:52Z

Hi @Lymah123,
How things going here? Do you need any help?

Lymah123 · 2023-12-28T20:39:22Z

Hi @Lymah123, How things going here? Do you need any help?

Hi @adiati98, you can review it now. Thank you!

adiati98

Hi @Lymah123,
Thanks for the changes! I gave you some feedback here. :)

Also, have you tested and run the docs locally?
Currently, there are unnecessary changes in the sidebars.js that are causing errors and shut the docs down locally, as shown in the screenshot below:

You might want to address this one first before working on the feedback. 😊

For future reference, you always want to run projects locally to test them and ensure they run properly.

docs/features/insights.md

sidebars.js

docs/features/insights.md

Lymah123 · 2023-12-29T20:06:30Z

Hi @adiati98, I have worked on the feedback. My branch is up to date. I ran my changes locally. It works perfectly. Besides, I didn't make changes to the sidebar section. What could be the issues?

adiati98 · 2023-12-29T20:18:56Z

@Lymah123, if you see your PR here, there are 2 file changes. One of them is the sidebar. I'm not sure if you accidentally changed it?

It's pretty weird that it can run locally on your end after running npm start with the changes in the sidebar. 🤔

I'll take a look at this tomorrow as I'm not on my computer anymore.

In the meantime, can you give a screenshot or screen recording when it runs on your machine so I can take a look at it tomorrow? Thanks. 🙂

Lymah123 · 2023-12-29T21:41:10Z

@adiati98 , I am not too sure. Do you support I should delete the repo, fork, then make the changes and submit a new PR?

CBID2 · 2023-12-29T23:14:09Z

@adiati98 , I am not too sure. Do you support I should delete the repo, fork, then make the changes and submit a new PR?

Hi @Lymah123. how about you try @adiati98's suggestion first? It might be a minor issue.

Lymah123 · 2023-12-29T23:38:19Z

@adiati98 , I am not too sure. Do you support I should delete the repo, fork, then make the changes and submit a new PR?

Hi @Lymah123. how about you try @adiati98's suggestion first? It might be a minor issue.

Hi @CBID2 , okay. I will work on her suggestion. Thank you.

sidebars.js

adiati98

Thanks for the changes, @Lymah123!

As you can now see in your PR, there is only one file that has changed. And that's what we want. 😊

I have a question for you here.
And FYI, I'm taking a few days off and will be back on 3rd January.
So, happy new year!

docs/features/insights.md

Lymah123 · 2023-12-31T12:11:10Z

Thanks for the changes, @Lymah123!

As you can now see in your PR, there is only one file that has changed. And that's what we want. 😊

I have a question for you here. And FYI, I'm taking a few days off and will be back on 3rd January. So, happy new year!

Awwnn! Happy New Year to you @adiati98! Always a pleasure having you review my PRs. Thanks for all the guidance you give. Looking forward to more of it in the coming year.

Lymah123 · 2023-12-31T12:16:46Z

I see that you marked all newest suggestions as resolved, but there are no changes applied as per suggestions.

It's totally okay if you don't take the suggestions, but it would be great if you provide the reasoning behind your thoughts in each suggestion. That way, reviewers can understand your ideas. 🙂

That said, would you please let me know why you don't apply them?

Regards this @adiati98 , I made changes to all the suggestions mentioned so far. A reason I marked them as resolved. You can reference anyone I didn't make changes to and I would gladly do that.

Thanks for always being patient with me @adiati98.

adiati98 · 2023-12-31T12:25:02Z

@Lymah123 you can click the "Files changed" tab in your PR. Then, you can see the reviews that I've unresolved.

I'll take a look at them once I'm back. 👍🏽

Lymah123 · 2023-12-31T12:29:13Z

@Lymah123 you can click the "Files changed" tab in your PR. Then, you can see the reviews that I've unresolved.

I'll take a look at them once I'm back. 👍🏽

Alright. I will do that.
Enjoy your break @adiati98.

Co-authored-by: Ayu Adiati <45172775+adiati98@users.noreply.github.com>

Lymah123 · 2024-01-02T18:28:30Z

@Lymah123 you can click the "Files changed" tab in your PR. Then, you can see the reviews that I've unresolved.

I'll take a look at them once I'm back. 👍🏽

Hi @adiati98, I have worked on unresolved suggestions.

adiati98

I would love to have final review from @BekahHW here.
But it looks good to me. Thank you, @Lymah123! 🙌

BekahHW

Great job, @Lymah123! We're good to go!

## [1.59.0](v1.58.0...v1.59.0) (2024-01-04) ### Features * Adds info on adding teammates to the insights page ([#230](#230)) ([d6b4681](d6b4681))

github-actions · 2024-01-04T19:26:56Z

🎉 This PR is included in version 1.59.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

* Add info on adding teammates to the insightd page * Update insights.md * Remove Storybook from sidebars.js * Update docs/features/insights.md Co-authored-by: Ayu Adiati <45172775+adiati98@users.noreply.github.com> * Update docs/features/insights.md Co-authored-by: Ayu Adiati <45172775+adiati98@users.noreply.github.com> * Update docs/features/insights.md Co-authored-by: Ayu Adiati <45172775+adiati98@users.noreply.github.com> * Update docs/features/insights.md Co-authored-by: Ayu Adiati <45172775+adiati98@users.noreply.github.com> * Update insights.md * Update insights.md * Update insights.md * Update sidebars.js * Update docs/features/insights.md Co-authored-by: Ayu Adiati <45172775+adiati98@users.noreply.github.com> * Update docs/features/insights.md Co-authored-by: Ayu Adiati <45172775+adiati98@users.noreply.github.com> --------- Co-authored-by: Ayu Adiati <retno.ayu98@gmail.com> Co-authored-by: BekahHW <34313413+BekahHW@users.noreply.github.com> Co-authored-by: Ayu Adiati <45172775+adiati98@users.noreply.github.com> d6b4681

Add info on adding teammates to the insightd page

21adfce

Update insights.md

bb944b9

adiati98 mentioned this pull request Dec 8, 2023

feat: Update Storybook documentation. #225

Closed

Remove Storybook from sidebars.js

291b5e6

adiati98 requested changes Dec 8, 2023

View reviewed changes

BekahHW and others added 4 commits December 8, 2023 13:16

Update docs/features/insights.md

0bc27f2

Co-authored-by: Ayu Adiati <45172775+adiati98@users.noreply.github.com>

Update docs/features/insights.md

7c4d3da

Co-authored-by: Ayu Adiati <45172775+adiati98@users.noreply.github.com>

Update docs/features/insights.md

b2fe021

Co-authored-by: Ayu Adiati <45172775+adiati98@users.noreply.github.com>

Update docs/features/insights.md

0fd4f92

Co-authored-by: Ayu Adiati <45172775+adiati98@users.noreply.github.com>

BekahHW requested changes Dec 8, 2023

View reviewed changes

adiati98 assigned Lymah123 Dec 8, 2023

adiati98 added the 📝 documentation label Dec 8, 2023

Merge branch 'main' into insight-page-update

67da868

CBID2 reviewed Dec 17, 2023

View reviewed changes

docs/features/insights.md Outdated Show resolved Hide resolved

Update insights.md

ae2d47f

Update insights.md

06f1ad8

adiati98 requested changes Dec 28, 2023

View reviewed changes

docs/features/insights.md Outdated Show resolved Hide resolved

docs/features/insights.md Outdated Show resolved Hide resolved

docs/features/insights.md Outdated Show resolved Hide resolved

sidebars.js Outdated Show resolved Hide resolved

adiati98 reviewed Dec 28, 2023

View reviewed changes

docs/features/insights.md Outdated Show resolved Hide resolved

adiati98 requested changes Dec 28, 2023

View reviewed changes

docs/features/insights.md Outdated Show resolved Hide resolved

docs/features/insights.md Outdated Show resolved Hide resolved

Update insights.md

b82baf4

adiati98 reviewed Dec 30, 2023

View reviewed changes

sidebars.js Outdated Show resolved Hide resolved

Update sidebars.js

6652772

adiati98 reviewed Dec 31, 2023

View reviewed changes

docs/features/insights.md Outdated Show resolved Hide resolved

Lymah123 and others added 2 commits January 2, 2024 19:26

Update docs/features/insights.md

0246316

Co-authored-by: Ayu Adiati <45172775+adiati98@users.noreply.github.com>

Update docs/features/insights.md

c60631c

Co-authored-by: Ayu Adiati <45172775+adiati98@users.noreply.github.com>

adiati98 approved these changes Jan 3, 2024

View reviewed changes

BekahHW approved these changes Jan 4, 2024

View reviewed changes

BekahHW merged commit d6b4681 into open-sauced:main Jan 4, 2024

github-actions bot pushed a commit that referenced this pull request Jan 4, 2024

chore(release): 1.59.0 [skip ci]

e65691f

## [1.59.0](v1.58.0...v1.59.0) (2024-01-04) ### Features * Adds info on adding teammates to the insights page ([#230](#230)) ([d6b4681](d6b4681))

github-actions bot added the released label Jan 4, 2024

Conversation

Lymah123 commented Dec 8, 2023

Description

What type of PR is this? (check all applicable)

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Steps to QA

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Uh oh!

netlify bot commented Dec 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👷 Deploy request for docs-open pending review.

Uh oh!

Lymah123 commented Dec 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adiati98 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BekahHW left a comment

Choose a reason for hiding this comment

Uh oh!

Lymah123 commented Dec 14, 2023

Uh oh!

CBID2 commented Dec 15, 2023

Uh oh!

Lymah123 commented Dec 15, 2023

Uh oh!

Lymah123 commented Dec 16, 2023

Uh oh!

Uh oh!

CBID2 commented Dec 17, 2023

Uh oh!

adiati98 commented Dec 28, 2023

Uh oh!

Lymah123 commented Dec 28, 2023

Uh oh!

adiati98 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Lymah123 commented Dec 29, 2023

Uh oh!

adiati98 commented Dec 29, 2023

Uh oh!

Lymah123 commented Dec 29, 2023

Uh oh!

CBID2 commented Dec 29, 2023

Uh oh!

Lymah123 commented Dec 29, 2023

Uh oh!

Uh oh!

adiati98 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Lymah123 commented Dec 31, 2023

Uh oh!

Lymah123 commented Dec 31, 2023

Uh oh!

adiati98 commented Dec 31, 2023

Uh oh!

Lymah123 commented Dec 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Lymah123 commented Jan 2, 2024

netlify bot commented Dec 8, 2023 •

edited

Loading

Lymah123 commented Dec 8, 2023 •

edited

Loading

Lymah123 commented Dec 31, 2023 •

edited

Loading

adiati98 left a comment •

edited

Loading