Paython mcp#15
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧩 Summary
This PR fixes the navigation and state persistence between the Configure and Secrets & Preflight pages. Users can now successfully generate a pipeline and continue to the secrets setup flow without losing context.
⸻
✅ Changes
• Updated NeedPipeline guard logic in App.tsx to correctly detect YAML generation in multiple response formats.
• Patched ConfigurePage to properly activate the Continue → Secrets button only when a valid pipeline is available.
• Added controlled navigation handling to prevent unnecessary re-renders.
• Verified role data parsing and AWS OIDC select binding.
• Added console tracepoints for pipeline and role debugging.
⸻
🧪 Testing Steps
1. Connect a GitHub repo via the Connect page.
2. Generate a CI/CD pipeline via the Configure page.
3. Confirm Continue → Secrets becomes active once YAML is generated.
4. Click to navigate — confirm the Secrets & Preflight page renders with:
• GitHub app ✅
• Repo info ✅
• AWS OIDC role ✅
5. Verify browser console logs show: