Fix C++11 ABI breakage when compiled with C++17 (https://github.com/open-source-parsers/jsoncpp/issues/1668)#1675
Open
Fix C++11 ABI breakage when compiled with C++17 (https://github.com/open-source-parsers/jsoncpp/issues/1668)#1675
Conversation
- Injects `FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true` in all workflows to opt-in to Node.js 24 and suppress the deprecation warnings from multiple GitHub Actions. - Specifies `python-version: '3.x'` for `actions/setup-python@v5` in `meson.yml` to fix the missing input warning.
When JSONCPP_HAS_STRING_VIEW was defined, the library dropped the `const char*` and `const String&` overloads for `operator[]`, `get`, `removeMember`, and `isMember`, breaking ABI compatibility for projects consuming the library with C++11. This change unconditionally declares and defines the legacy overloads so they are always exported, restoring compatibility.
baylesj
changed the title
Coverage Report for CI Build 24118690154Coverage remained the same at 90.093%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
JSONCPP_HAS_STRING_VIEWis defined while JsonCpp is built, but not in a consuming library, theconst char*andconst String&overloads foroperator[],get,removeMember, andisMemberare defined in the header but do not have an implementation, breaking ABI compatibility for projects consuming the library with C++11.This change unconditionally declares and defines the legacy overloads so they are always exported, restoring compatibility.