[API] Deprecate opentelemetry::plugin#4021
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4021 +/- ##
==========================================
+ Coverage 81.94% 82.05% +0.12%
==========================================
Files 389 385 -4
Lines 15927 15891 -36
==========================================
- Hits 13049 13038 -11
+ Misses 2878 2853 -25 🚀 New features to boost your workflow:
|
|
Thanks, will have a look now. |
|
Good to deprecate, but as per the deprecation process, we should be adding this in each public header deprecated: #ifdef OPENTELEMETRY_NO_DEPRECATED_CODE
# error "header <opentelemetry/foo.h> is deprecated."
#endif |
I don't think anyone will see this, it supposes building with OPENTELEMETRY_NO_DEPRECATED_CODE in the first place. Added warnings in all cases for visibility, as well as the error in no-deprecated builds, for more safety. Note that I commented out CMake and bazel then, so we don't see this ourselves. |
Oh yes, My earlier comment was based on the current docs/deprecation-process.md guidance for deprecated public headers, which explicitly calls for the That said, I agree that the I think we should do the follow-up PR to update |
Fixes # (issue)
Changes
Please provide a brief description of the changes here.
opentelemetry::pluginnamespaceThe code is commented out for now, for easier rollback if so required.
File removal, including tests, examples and CI, to be done in the final removal PR.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes