Static instrumenter - core #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
Author
|
@java-contrib-approvers I'd love to get some feedback on this PR |
anuraaga
reviewed
Mar 7, 2022
...-instrumenter/src/main/java/io/opentelemetry/contrib/statical/instrumenter/ArchiveEntry.java
Outdated
Show resolved
Hide resolved
...-instrumenter/src/main/java/io/opentelemetry/contrib/statical/instrumenter/ClassArchive.java
Outdated
Show resolved
Hide resolved
...er/agent-instrumenter/src/main/java/io/opentelemetry/contrib/statical/instrumenter/Main.java
Outdated
Show resolved
Hide resolved
...er/agent-instrumenter/src/main/java/io/opentelemetry/contrib/statical/instrumenter/Main.java
Outdated
Show resolved
Hide resolved
...t-instrumenter/src/main/java/io/opentelemetry/contrib/statical/instrumenter/StreamUtils.java
Outdated
Show resolved
Hide resolved
...trumenter/src/test/java/io/opentelemetry/contrib/statical/instrumenter/ClassArchiveTest.java
Show resolved
Hide resolved
...t-instrumenter/src/test/java/io/opentelemetry/contrib/statical/instrumenter/JarTestUtil.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
Author
Thanks a lot! Looking forward to merging this and following up with the rest of the code :) |
...er/agent-instrumenter/src/main/java/io/opentelemetry/contrib/statical/instrumenter/Main.java
Outdated
Show resolved
Hide resolved
...er/agent-instrumenter/src/main/java/io/opentelemetry/contrib/statical/instrumenter/Main.java
Outdated
Show resolved
Hide resolved
...-instrumenter/src/main/java/io/opentelemetry/contrib/statical/instrumenter/ClassArchive.java
Outdated
Show resolved
Hide resolved
...-instrumenter/src/main/java/io/opentelemetry/contrib/statical/instrumenter/ClassArchive.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
trask
reviewed
Mar 14, 2022
...-instrumenter/src/main/java/io/opentelemetry/contrib/statical/instrumenter/ArchiveEntry.java
Outdated
Show resolved
Hide resolved
...er/agent-instrumenter/src/main/java/io/opentelemetry/contrib/statical/instrumenter/Main.java
Show resolved
Hide resolved
...er/agent-instrumenter/src/main/java/io/opentelemetry/contrib/statical/instrumenter/Main.java
Outdated
Show resolved
Hide resolved
...er/agent-instrumenter/src/main/java/io/opentelemetry/contrib/statical/instrumenter/Main.java
Outdated
Show resolved
Hide resolved
...er/agent-instrumenter/src/main/java/io/opentelemetry/contrib/statical/instrumenter/Main.java
Outdated
Show resolved
Hide resolved
...-instrumenter/src/main/java/io/opentelemetry/contrib/statical/instrumenter/ClassArchive.java
Outdated
Show resolved
Hide resolved
...er/agent-instrumenter/src/main/java/io/opentelemetry/contrib/statical/instrumenter/Main.java
Show resolved
Hide resolved
...-instrumenter/src/main/java/io/opentelemetry/contrib/statical/instrumenter/ClassArchive.java
Show resolved
Hide resolved
...-instrumenter/src/main/java/io/opentelemetry/contrib/statical/instrumenter/ClassArchive.java
Outdated
Show resolved
Hide resolved
...-instrumenter/src/main/java/io/opentelemetry/contrib/statical/instrumenter/ClassArchive.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Author
|
Another round done :) |
trask
reviewed
Mar 16, 2022
Member
trask
left a comment
trask
left a comment
There was a problem hiding this comment.
a couple suggestions around ArchiveFile (since keeping it 😄)
...ent-instrumenter/src/main/java/io/opentelemetry/contrib/staticinstrumenter/ArchiveEntry.java
Outdated
Show resolved
Hide resolved
...ent-instrumenter/src/main/java/io/opentelemetry/contrib/staticinstrumenter/ArchiveEntry.java
Outdated
Show resolved
Hide resolved
...ent-instrumenter/src/main/java/io/opentelemetry/contrib/staticinstrumenter/ClassArchive.java
Outdated
Show resolved
Hide resolved
anuraaga
reviewed
Mar 17, 2022
...ent-instrumenter/src/main/java/io/opentelemetry/contrib/staticinstrumenter/ArchiveEntry.java
Outdated
Show resolved
Hide resolved
...ent-instrumenter/src/main/java/io/opentelemetry/contrib/staticinstrumenter/ArchiveEntry.java
Show resolved
Hide resolved
...ent-instrumenter/src/main/java/io/opentelemetry/contrib/staticinstrumenter/ArchiveEntry.java
Outdated
Show resolved
Hide resolved
...ent-instrumenter/src/main/java/io/opentelemetry/contrib/staticinstrumenter/ClassArchive.java
Outdated
Show resolved
Hide resolved
...ent-instrumenter/src/main/java/io/opentelemetry/contrib/staticinstrumenter/ClassArchive.java
Outdated
Show resolved
Hide resolved
...enter/agent-instrumenter/src/main/java/io/opentelemetry/contrib/staticinstrumenter/Main.java
Outdated
Show resolved
Hide resolved
...instrumenter/src/test/java/io/opentelemetry/contrib/staticinstrumenter/ClassArchiveTest.java
Outdated
Show resolved
Hide resolved
...instrumenter/src/test/java/io/opentelemetry/contrib/staticinstrumenter/ClassArchiveTest.java
Outdated
Show resolved
Hide resolved
...r/agent-instrumenter/src/test/java/io/opentelemetry/contrib/staticinstrumenter/MainTest.java
Outdated
Show resolved
Hide resolved
...-instrumenter/src/main/java/io/opentelemetry/contrib/staticinstrumenter/PostTransformer.java
Outdated
Show resolved
Hide resolved
Author
|
Another round done. |
trask
approved these changes
Mar 18, 2022
Member
trask
left a comment
trask
left a comment
There was a problem hiding this comment.
thx @kubawach, looking forward to the next PR!
...ent-instrumenter/src/main/java/io/opentelemetry/contrib/staticinstrumenter/ClassArchive.java
Outdated
Show resolved
Hide resolved
...enter/agent-instrumenter/src/main/java/io/opentelemetry/contrib/staticinstrumenter/Main.java
Outdated
Show resolved
Hide resolved
...-instrumenter/src/main/java/io/opentelemetry/contrib/staticinstrumenter/PostTransformer.java
Outdated
Show resolved
Hide resolved
...enter/agent-instrumenter/src/main/java/io/opentelemetry/contrib/staticinstrumenter/Main.java
Outdated
Show resolved
Hide resolved
mateuszrzeszutek
approved these changes
Mar 22, 2022
anosek-an
approved these changes
Mar 22, 2022
Member
|
thx @kubawach! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Core part of the static instrumenter - command line tool enabling modified jar copy.
Existing Issue(s):
Part of #156
Testing:
Documentation:
README updated
Outstanding items: