Migrate build from Groovy to Kotlin DSL#247
Merged
Merged
Conversation
AlexCzar
commented
Nov 8, 2023
Contributor
|
Could use a rebase, sorry @AlexCzar |
breedx-splk
approved these changes
Nov 13, 2023
Contributor
breedx-splk
left a comment
breedx-splk
left a comment
There was a problem hiding this comment.
Thanks for taking this on!
Contributor
Author
|
Will probably have to wait for the weekend. |
As suggested in migrate to Kotlin DSL, review, move the checks inside the block instead of duplicating the block within the if branches.
Contributor
Author
|
Rebased and addressed the comment about the |
Member
oh no, sorry! I missed this and just merged several |
Member
|
I will fix merge conflicts... |
Member
|
thanks @AlexCzar! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #222