-
Notifications
You must be signed in to change notification settings - Fork 152
add Spring declarative config example #911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Spring declarative config example #911
Conversation
45bf4d2 to
524a739
Compare
524a739 to
dd55d82
Compare
dd55d82 to
4476bdc
Compare
|
@trask it's good to go 😄 |
8fcaa90 to
4c8443e
Compare
| In many cases, you can start with declarative configuration (as in this module) and only fall back | ||
| to programmatic customization for highly dynamic or application-specific logic. | ||
|
|
||
| ## Troubleshooting and Tips |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this readme is already pretty long, i wonder if this section could be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copilot going loose... I'll revisit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd leave it in - I do plan to move some of this content to the general docs after the next release, which contains some bug related fixes.
| http.route: "/api/example" | ||
| - traceql: '{ span.http.route = "/actuator/health" }' | ||
| count: | ||
| max: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 🎉
Co-authored-by: Jay DeLuca <jaydeluca4@gmail.com>
|
@trask can you take a look? |
No description provided.