add IncludeExcludePredicate test when value matches both include and exclude#8371
Merged
jack-berg merged 1 commit intoopen-telemetry:mainfrom May 5, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8371 +/- ##
=========================================
Coverage 90.83% 90.83%
Complexity 7927 7927
=========================================
Files 895 895
Lines 23872 23872
Branches 2378 2378
=========================================
Hits 21683 21683
Misses 1446 1446
Partials 743 743 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zeitlinger
approved these changes
May 5, 2026
jack-berg
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From open-telemetry/opentelemetry-java-contrib#2802 (review) : add explicit test when both include and exclude are matching the provided value.
The implementation already fits the current spec, when value matches both include and exclude, then it's excluded by default.