Skip to content

add IncludeExcludePredicate test when value matches both include and exclude#8371

Merged
jack-berg merged 1 commit intoopen-telemetry:mainfrom
SylvainJuge:test-include-exclude-matching-both
May 5, 2026
Merged

add IncludeExcludePredicate test when value matches both include and exclude#8371
jack-berg merged 1 commit intoopen-telemetry:mainfrom
SylvainJuge:test-include-exclude-matching-both

Conversation

@SylvainJuge
Copy link
Copy Markdown
Contributor

From open-telemetry/opentelemetry-java-contrib#2802 (review) : add explicit test when both include and exclude are matching the provided value.

The implementation already fits the current spec, when value matches both include and exclude, then it's excluded by default.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.83%. Comparing base (b1b563b) to head (f3626ff).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #8371   +/-   ##
=========================================
  Coverage     90.83%   90.83%           
  Complexity     7927     7927           
=========================================
  Files           895      895           
  Lines         23872    23872           
  Branches       2378     2378           
=========================================
  Hits          21683    21683           
  Misses         1446     1446           
  Partials        743      743           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jack-berg jack-berg merged commit 0aa7828 into open-telemetry:main May 5, 2026
28 checks passed
@SylvainJuge SylvainJuge deleted the test-include-exclude-matching-both branch May 5, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants