Add BatchSpanProcessor.create(SpanExporter) to match SimpleSpanProcessor#8564
Open
jimbobbennett wants to merge 1 commit into
Open
Add BatchSpanProcessor.create(SpanExporter) to match SimpleSpanProcessor#8564jimbobbennett wants to merge 1 commit into
jimbobbennett wants to merge 1 commit into
Conversation
|
|
Contributor
|
Author
|
/easycla |
`SimpleSpanProcessor` exposes both `create(SpanExporter)` and `builder(SpanExporter)`, but `BatchSpanProcessor` only exposed `builder(SpanExporter)`. This asymmetry is an easy trap: since `SimpleSpanProcessor.create(exporter)` compiles, it's natural to assume `BatchSpanProcessor.create(exporter)` does too. Add a `create(SpanExporter)` factory to `BatchSpanProcessor` returning a default-configured processor (equivalent to `builder(exporter).build()`), mirroring `SimpleSpanProcessor`. Purely additive and backward-compatible. Fixes open-telemetry#8561
jimbobbennett
force-pushed
the
batch-span-processor-create
branch
from
32c0d45 to
4e459b3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8564 +/- ##
=========================================
Coverage 90.96% 90.96%
- Complexity 10207 10209 +2
=========================================
Files 1013 1013
Lines 27160 27162 +2
Branches 3182 3182
=========================================
+ Hits 24706 24709 +3
Misses 1730 1730
+ Partials 724 723 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
BatchSpanProcessor.create(SpanExporter)convenience factory returning a default-configured processor (equivalent tobuilder(exporter).build()), mirroring the existingSimpleSpanProcessor.create(SpanExporter).Why
SimpleSpanProcessorexposes bothcreate(SpanExporter)andbuilder(SpanExporter), butBatchSpanProcessoronly exposedbuilder(SpanExporter). SinceSimpleSpanProcessor.create(exporter)compiles, it's natural to assumeBatchSpanProcessor.create(exporter)does too — but it fails withcannot find symbol: method create(SpanExporter). This is purely additive and backward-compatible; the builder stays for configuration.Fixes #8561
Details
create(SpanExporter)static factory with@since 1.64.0Javadoc.SimpleSpanProcessor.createDefaults()andcreateNull().docs/apidiffs/current_vs_latest/opentelemetry-sdk-trace.txt.