Skip to content

adding documentation for using opentelemetry-distro#1813

Merged
codeboten merged 5 commits intoopen-telemetry:mainfrom
codeboten:codeboten/docs-distro
May 7, 2021
Merged

adding documentation for using opentelemetry-distro#1813
codeboten merged 5 commits intoopen-telemetry:mainfrom
codeboten:codeboten/docs-distro

Conversation

@codeboten
Copy link
Copy Markdown
Contributor

Description

Fixes #1606

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Does This PR Require a Contrib Repo Change?

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Documentation has been updated

Documentation looks like this Screen Shot 2021-05-04 at 9 18 39 AM

@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 4, 2021
@codeboten codeboten requested review from a team, aabmass and srikanthccv and removed request for a team May 4, 2021 16:19

$ opentelemetry-instrument python no_configuration.py

The resulting span will appear in the output from the collector.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Maybe also add what the resulting output looks like?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Copy Markdown
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Should we also update the auto instrumentation docs pointing to this and recommend installing otel distro if they don't already have some vendor distro dependency?

@codeboten
Copy link
Copy Markdown
Contributor Author

@lonewolf3739 sure I can add a PR in the contrib repo for this.

@srikanthccv
Copy link
Copy Markdown
Member

srikanthccv commented May 6, 2021

That would be really nice. It is not easily discoverable/obvious for new comers.

@codeboten codeboten merged commit 3a0d38f into open-telemetry:main May 7, 2021
@codeboten codeboten deleted the codeboten/docs-distro branch May 7, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenTelemetry distro as a default distro for OpenTelemetry Instrumentation

4 participants