Add dynamic headers to Exporter constructor#4431
Closed
DylanRussell wants to merge 0 commit intoopen-telemetry:mainfrom
Closed
Add dynamic headers to Exporter constructor#4431DylanRussell wants to merge 0 commit intoopen-telemetry:mainfrom
DylanRussell wants to merge 0 commit intoopen-telemetry:mainfrom
Conversation
|
|
Member
|
Same comment as #4432. |
Contributor
|
Sure, but why a generator and not a callable? |
Contributor
|
Other projects solved this issue, Custom credentials: https://aiodynamo.readthedocs.io/en/latest/advanced.html#custom-credentials-loader Overall use: https://aiodynamo.readthedocs.io/en/latest/quickstart.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The draft PR prototypes adding
additional_dynamic_headersto OTLP gRPC / HTTP Exporter constructor.Additional dynamic headers is a map where the key is the header name and the value is a generator function which produces the header value when called. These header functions are called on each call to export.
Google needs something like this in order to set the Authorization header, which periodically needs to be refreshed and updated.
Here's how we'd use this new constructor:
Java has something similar