Skip to content

Conversation

@majanjua-amzn
Copy link

@majanjua-amzn majanjua-amzn commented Nov 28, 2025

Description

Adds a new AlwaysRecordSampler as per:

This sampler behaves the same as it's root sampler, with the exception that it will replace any DROP decisions with an equivalent RECORD one, while maintaining the attributes and trace state from the decision created by the root sampler.

Also renamed the folder holding the tests for experimental sampling features from composite_sampler to sampling_experimental, as more than just the composite sampler is being tested in this folder, respecting the organization of the files in the src folder.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Unit tests

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@majanjua-amzn majanjua-amzn requested a review from a team as a code owner November 28, 2025 00:00
@xrmx
Copy link
Contributor

xrmx commented Nov 28, 2025

We need to wait for the specs to be approved and released before merging this

@xrmx xrmx moved this to Ready for review in @xrmx's Python PR digest Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready for review

Development

Successfully merging this pull request may close these issues.

2 participants