Fix otcollector README#500
Merged
toumorokoshi merged 3 commits intoopen-telemetry:masterfrom Mar 23, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #500 +/- ##
=======================================
Coverage 89.33% 89.33%
=======================================
Files 43 43
Lines 2176 2176
Branches 248 248
=======================================
Hits 1944 1944
Misses 161 161
Partials 71 71 Continue to review full report at Codecov.
|
|
|
||
| * `OpenTelemetry Collector <https://github.com/open-telemetry/opentelemetry-collector/>`_ | ||
| * `OpenTelemetry Project <https://opentelemetry.io/>`_ | ||
| * `OpenTelemetry <https://opentelemetry.io/>`_ |
There was a problem hiding this comment.
Is it actually fixing a syntax error?
Member
There was a problem hiding this comment.
OpenTelemetry Project is the actual thing we use in other readme files
Member
Author
There was a problem hiding this comment.
Actually a syntax error. Either this line or L22 needs to change.
% python -m readme_renderer ext/opentelemetry-ext-otcollector/README.rst
<string>:22: (ERROR/3) Unknown target name: "opentelemetry".
hectorhdzg
approved these changes
Mar 18, 2020
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
* feat: add ConsoleMetricExporter * fix: review comments * fix: linting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #445, which would have caught this.