feat(config): honor OTEL_CONFIG_FILE in the SDK configurator#5271
Draft
MikeGoldsmith wants to merge 18 commits into
Draft
feat(config): honor OTEL_CONFIG_FILE in the SDK configurator#5271MikeGoldsmith wants to merge 18 commits into
MikeGoldsmith wants to merge 18 commits into
Conversation
Adds `_dict_to_dataclass` in `_conversion.py` which walks each field's type annotation and converts: - nested dicts → typed dataclass instances - lists of dicts → lists of typed dataclasses - string/value → Enum members (e.g. log_level: info) - unknown keys → routed to the @_additional_properties decorator The loader's `_dict_to_model` now produces a fully-typed OpenTelemetryConfiguration tree end-to-end. Factory functions can rely on typed attribute access (config.tracer_provider.processors[0].batch .exporter.otlp_http.endpoint) instead of failing on raw dicts. This closes the gap between load_config_file() and the factory functions — YAML/JSON config → SDK objects now works end-to-end. Closes open-telemetry#5127 Assisted-by: Claude Opus 4.6
- Use TypeVar for _dict_to_dataclass return — callers now get the correct type instead of Any - Use collections.abc.Mapping for input (more permissive than dict) - Add explicit is_dataclass check at entry — raises TypeError with a descriptive message instead of failing later in dataclasses.fields Assisted-by: Claude Opus 4.6
Astroid 3.x (used by pylint 3.x) follows typing.get_type_hints into Python 3.14's annotationlib, which contains t-string literals it can't parse and crashes with AttributeError on 'visit_templatestr'. Wrapping the call in a helper that returns dict[str, Any] stops the inference at the declared return type. Assisted-by: Claude Opus 4.7
Same effect as the prior helper — declaring the local as ``dict[str, Any]`` stops astroid's inference at the annotation rather than tracing into the typing internals. Assisted-by: Claude Opus 4.7
Single entry point that takes a parsed OpenTelemetryConfiguration, builds the resource, and applies the tracer/meter/logger providers and propagator globally. Honors the top-level disabled flag — when true, no globals are touched. The orchestrator is a thin composition of the existing per-signal configure_* factories; the deeper unification with the env-var path (see open-telemetry#5126) is left for follow-up. Refs open-telemetry#3631 Refs open-telemetry#5126 Assisted-by: Claude Opus 4.7
Assisted-by: Claude Opus 4.7
When the environment variable is set, route the SDK through the declarative config path — load the file via load_config_file() and apply it via configure_sdk() — in place of the env-var-based _initialize_components(). Other OTEL_* vars are ignored (per spec v1.0.0: when a config file is given, it is the sole source of truth). Kwargs passed to _OTelSDKConfigurator._configure are ignored with a warning when the file path is set, so distros that inject kwargs via super() see a clear signal rather than silent drops. The file-loader imports (pyyaml, jsonschema) stay lazy so installs without the file-configuration extras are not affected. Refs open-telemetry#3631 Assisted-by: Claude Opus 4.7
Assisted-by: Claude Opus 4.7
27 tasks
… codespell Replace the bespoke _Level enum (which violated pylint's invalid-name on lowercase members) with the real ExemplarFilter enum from models.py — the generated models use lowercase values verbatim from the JSON schema, so using one of them avoids fighting the linter and exercises the same code path with real data shapes. Add 'astroid' to codespell's ignore-words-list; the prior commit's explanatory comment mentions the library by name and codespell flagged it as a misspelling of 'asteroid'. Assisted-by: Claude Opus 4.7
Move ``SdkTracerProvider`` import to module top (ruff PLC0415 / pylint C0415) and add explicit ``# pylint: disable=no-self-use`` on the three mock-only tests that intentionally do not touch ``self``. Assisted-by: Claude Opus 4.7
The configure_sdk / load_config_file imports inside ``_configure`` are deliberately deferred so that the SDK does not pull in the optional file-configuration extras (pyyaml, jsonschema) unless ``OTEL_CONFIG_FILE`` is actually set. Annotate with the corresponding pylint and ruff suppressions; the existing comment already explains why. Assisted-by: Claude Opus 4.7
Assisted-by: Claude Opus 4.7
Assisted-by: Claude Opus 4.7
MikeGoldsmith
added
the
Approve Public API check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wires the SDK entry point to honor the
OTEL_CONFIG_FILEenvironment variable. When set,_OTelSDKConfigurator._configureloads the referenced YAML/JSON file viaload_config_file()and applies it viaconfigure_sdk()— bypassing the existing env-var-based_initialize_components()path entirely.Per spec v1.0.0: when a config file is given, it is the sole source of truth; other
OTEL_*variables are ignored except as${env:VAR}substitutions inside the file.Behavior
_initialize_components(**kwargs)path. No change.configure_sdk(load_config_file(path)). Other env vars ignored._OTelSDKConfiguratorand inject kwargs viasuper()._configure(**kwargs)). The file is authoritative.ConfigurationErrorpropagates. Loud failure per spec.Implementation notes
OTEL_CONFIG_FILEconstant added toopentelemetry.sdk.environment_variables.if config_file:branch so the SDK does not require[file-configuration]extras unless a config file is actually used.Refs #3631
Type of change
How Has This Been Tested?
5 new tests in
tests/_configuration/test_configurator_file_routing.py:_initialize_componentscalled with passed kwargs (existing behavior preserved)configure_sdk(load_config_file(path))called;_initialize_componentsNOT calledConfigurationErrorpropagatessuper()._configure) still works when env var is unsetManually smoke-tested end-to-end: with a minimal YAML file, the SDK
TracerProvideris constructed with the configured processor.Does This PR Require a Contrib Repo Change?
Checklist:
Note
This PR is stacked on top of #5269 → #5270. The diff includes both upstream PRs' changes until they land; rebase will clean it up. Transient failures expected until then:
changelog— validator flags5269.addedand5270.addedas added on this PR (resolves as each lands)public-symbols-check—OTEL_CONFIG_FILEis a new public symbol onopentelemetry.sdk.environment_variables. Intentional (env vars are public API contract). Needs an "Approve Public API check" label from a maintainer.