Docs: fix docs dependencies#625
Merged
c24t merged 4 commits intoopen-telemetry:masterfrom Apr 30, 2020
mauriciovasquezbernal:mauricio/fix-docs-dependencies
Merged
Docs: fix docs dependencies#625c24t merged 4 commits intoopen-telemetry:masterfrom mauriciovasquezbernal:mauricio/fix-docs-dependencies
c24t merged 4 commits intoopen-telemetry:masterfrom
mauriciovasquezbernal:mauricio/fix-docs-dependencies
Conversation
ocelotl
approved these changes
Apr 29, 2020
Contributor
ocelotl
left a comment
ocelotl
left a comment
There was a problem hiding this comment.
LGTM 👍
Approving, just minor cosmetic changes requested.
c24t
approved these changes
Apr 30, 2020
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
* feat: introduce ended property on Span Add a getter to Span and ReadableSpan to allow checking if the span is ended without using a private field or rely on internals like span.duration[0] < 0. Refs: open-telemetry/opentelemetry-java#693 Refs: open-telemetry/opentelemetry-java#697 * chore: adapt after merge from master * chore: revert changes in API * chore: remove unneeded isEnded
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview available at https://opentelemetry-python-mauricio.readthedocs.io/en/mauricio-fix-docs-dependencies/.