Skip to content

Docs for Pyramid and SQLite3#806

Merged
toumorokoshi merged 4 commits intoopen-telemetry:masterfrom
cnnradams:pyramid_instrumentation
Jun 13, 2020
Merged

Docs for Pyramid and SQLite3#806
toumorokoshi merged 4 commits intoopen-telemetry:masterfrom
cnnradams:pyramid_instrumentation

Conversation

@cnnradams
Copy link
Copy Markdown
Member

@cnnradams cnnradams commented Jun 10, 2020

I missed this in my last 2 instrumentation PRs 😬

Also did some formatting for the Pyramid docs

Fixes #805

@cnnradams cnnradams requested a review from a team June 10, 2020 22:00
Copy link
Copy Markdown
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, just a non-blocking question

Copy link
Copy Markdown
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@toumorokoshi toumorokoshi merged commit 74f2159 into open-telemetry:master Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ext/pyramid: add docs page

3 participants