chore: moving code to prepare the release to eachdist#808
Merged
toumorokoshi merged 7 commits intoopen-telemetry:masterfrom Jun 16, 2020
Merged
chore: moving code to prepare the release to eachdist#808toumorokoshi merged 7 commits intoopen-telemetry:masterfrom
toumorokoshi merged 7 commits intoopen-telemetry:masterfrom
Conversation
Contributor
|
Does |
Contributor
Author
No, prepare_release.sh still deals with git commands and version parsing |
ocelotl
suggested changes
Jun 11, 2020
Contributor
ocelotl
left a comment
ocelotl
left a comment
There was a problem hiding this comment.
IMHO, when it comes to generate files from arguments it is better to use Jinja templates.
ocelotl
approved these changes
Jun 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving some of the prepare_release.sh script into eachdist.py to clean up the process to prepare a release.