chore: Making eachdist release catch more deps#867
Merged
toumorokoshi merged 4 commits intoopen-telemetry:masterfrom Jul 2, 2020
Merged
Conversation
In the last release, eachdist missed updating dependencies on ext-datadog, which has a slightly different, but valid, way of specifying the version (omitting some spaces). Making the eachdist regex more lenient to catch other valid version specifications. Also modifying the ext-datadog dependency specification to match the format of all the others.
majorgreys
approved these changes
Jul 2, 2020
codeboten
pushed a commit
that referenced
this pull request
Jul 7, 2020
In the last release, eachdist missed updating dependencies on ext-datadog, which has a slightly different, but valid, way of specifying the version (omitting some spaces). Making the eachdist regex more lenient to catch other valid version specifications. Also modifying the ext-datadog dependency specification to match the format of all the others. Co-authored-by: Leighton Chen <lechen@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the last release, eachdist missed updating dependencies
on ext-datadog, which has a slightly different, but valid,
way of specifying the version (omitting some spaces).
Making the eachdist regex more lenient to catch other valid
version specifications.
Also modifying the ext-datadog dependency specification to
match the format of all the others.