Merged
Conversation
added 2 commits
July 2, 2020 17:20
added 2 commits
July 3, 2020 10:39
kintel
approved these changes
Jul 3, 2020
sjbrunst
approved these changes
Jul 3, 2020
ext/opentelemetry-exporter-cloud-trace/tests/test_cloud_trace_exporter.py
Outdated
Show resolved
Hide resolved
ocelotl
approved these changes
Jul 3, 2020
|
|
||
|
|
||
| def _strip_characters(ot_version): | ||
| return "".join(filter(lambda x: x.isdigit() or x == ".", ot_version)) |
Contributor
There was a problem hiding this comment.
Could also be implemented as:
from re import sub
sub(r"[^\d.], "", ot_version)
Contributor
Author
There was a problem hiding this comment.
I feel like the current way is a bit more readable, regex is a bit too compact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Google cloud trace exporter exports an additional label with all spans of the form
g.co/agent: "opentelemetry-python <ot_version>; google-cloud-trace-exporter <exporter_version>"
Currently, <ot_version> and <exporter_version> can have values "0.10.0b". The "b" makes it difficult for internal metrics at Google, so this PR removes those non numeric characters.