Skip to content

chore: Update appraisals of google-protobuf #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kaylareopelle wants to merge 2 commits into from
Closed

chore: Update appraisals of google-protobuf #1753

kaylareopelle wants to merge 2 commits into from

Conversation

@kaylareopelle
Copy link
Contributor

@kaylareopelle kaylareopelle commented Oct 22, 2024

The google-protobuf gem has a 4.x release. Also, our minimum supported version is now 3.18.0.

This PR updates the Appraisals file for the OTLP exporter and the OTLP metrics exporter to test different versions.

@kaylareopelle kaylareopelle marked this pull request as ready for review October 22, 2024 20:21
arielvalentin
arielvalentin reviewed Nov 15, 2024
View reviewed changes
Copy link
Contributor

@arielvalentin arielvalentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like protobuf as are backward compatible?

What is different in these major version changes?

Do we need to regenerate any source to target 4.x version of the gem?

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024

👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot

@github-actions github-actions bot added the stale label Dec 16, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2025

👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot

@github-actions github-actions bot added the stale label Feb 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2025

👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot

@github-actions github-actions bot added the stale label Mar 27, 2025
@kaylareopelle kaylareopelle mentioned this pull request Apr 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arielvalentin arielvalentin arielvalentin left review comments

@mwear mwear mwear approved these changes

@fbogsany fbogsany Awaiting requested review from fbogsany fbogsany is a code owner

@robertlaurin robertlaurin Awaiting requested review from robertlaurin robertlaurin is a code owner

@dazuma dazuma Awaiting requested review from dazuma dazuma is a code owner

@ericmustin ericmustin Awaiting requested review from ericmustin ericmustin is a code owner

@ahayworth ahayworth Awaiting requested review from ahayworth ahayworth is a code owner

@plantfansam plantfansam Awaiting requested review from plantfansam plantfansam is a code owner

@robbkidd robbkidd Awaiting requested review from robbkidd robbkidd is a code owner

Assignees

No one assigned

Labels

stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kaylareopelle @arielvalentin @mwear