[Bug]: Support tokio >1.38

[amfaber]

What happened?

The opentelemetry project currently requires tokio "~1.38.0", as changed in this commit 57bcd59

The comment indicates that this is to not require a bump of OTel's msrv from 1.65 to 1.70.
However, this requirement prevents projects that want to use OTel's crates from using newer tokio versions, even if they have a rust version that is way newer than 1.70 (as is my case).

Perhaps the requirement could be reverted to just "1" to allow consumers to choose the tokio version, with some other workaround for CI? I am not sure what the best way forward is.

API Version

0.24

SDK Version

0.24

What Exporter(s) are you seeing the problem on?

No response

Relevant log output

No response

[lalitb]

We can do msrv patching specific to CI as done here - #2081
@amfaber if you would like to contribute, else I can do this sometime this week.

[frederikhors]

cargo update
    Updating crates.io index
error: failed to select a version for `tokio`.
    ... required by package `opentelemetry_sdk v0.25.0`
    ... which satisfies dependency `opentelemetry_sdk = "^0.25.0"` of package `name v0.1.0`
    ... which satisfies path dependency `name` of package `app v0.1.0`
versions that meet the requirements `~1.38.0` are: 1.38.1, 1.38.0

all possible versions conflict with previously selected packages.

  previously selected package `tokio v1.40.0`
    ... which satisfies dependency `tokio = "^1.40.0"` of package `app v0.1.0`

failed to select a version for `tokio` which could resolve this conflict

[amfaber]

Incredible speed of resolution! Big ups and thank you 👍

[davidbarsky]

Commenting here because I had to help resolve a similar issue at work: it's generally not the best idea to have modifiers/operators in a Cargo.toml: checking in a Cargo.lock should be sufficient.

[aumetra]

Just out of curiosity, is there a patch release planned to release this?

[cijothomas]

No patch planned, as we are targeting to do the next release in ~3 weeks time. Given that there is release every ~3 weeks from now (till 1.0), do you really want a patch?

[frederikhors]

Why it is so difficult to release a patch?

[cijothomas]

Why it is so difficult to release a patch?

We are not saying it is very difficult. There is some amount of work to be done to release patches. Trying to avoid it unless there is an actual demand to do so, given we plan more frequently releases going fwd.

If you really need a patch release, please reply and we can do that.

[cijothomas]

@aumetra @frederikhors @amfaber Please comment here and let us know if you need us to push a patch release with this change.

[amfaber]

No need from my side

[aumetra]

Thanks for the ping! I personally don't necessarily need it, I can just downgrade tokio for now. I was just asking out of curiosity :P