Skip to content

Conversation

@bodymindarts
Copy link
Contributor

Fix order of arguments to SpanRef::new in opentelemetry-jaeger crate.

Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@jtescher
Copy link
Member

Just have to sign the CLA 👍

@bodymindarts
Copy link
Contributor Author

For stupid reasons I'm locked out of my linuxfoundation account and cannot associate this GitHub account with a new one. Is there another way?
I agree to the CLA! Just I have no idea when I'll be able to sign it because of the situation.

@jtescher
Copy link
Member

Hm I can see if there is another way to approve it, at worst this change can be done in another PR if you don't require attribution in git.

@bodymindarts
Copy link
Contributor Author

Cool... I would like attribution if its possible. Give me a few days to see if I can find a solution or else someone else can commit the fix if there is no other way.

@bodymindarts
Copy link
Contributor Author

Okay I regained access and was able to sign the CLA. Don't know why it says its still required. I signed as an individual.

@jtescher
Copy link
Member

Great it picked that up, just waiting on #120 to have the nightly checks not block merging.

@jtescher jtescher merged commit acc2f5f into open-telemetry:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants