Skip to content

Conversation

@swilcox3
Copy link
Contributor

This example shows a more advanced setup and integration with tracing. I think this would be helpful to show a more realistic production environment.
One concern I have is that the example Cargo.toml has to rely on the crates.io version of opentelemetry, because tracing-opentelemetry relies on that crates.io version as well. Maybe this example should be in the tracing-opentelemetry repository, but I couldn't find that.

@swilcox3 swilcox3 requested a review from a team May 28, 2020 15:51
@jtescher
Copy link
Member

Thanks! Probably good idea to show a tracing-opentelemetry example in this repo. (The tracing-opentelemetry source is now in the tracing repo https://github.com/tokio-rs/tracing/tree/master/tracing-opentelemetry). But the example there would have a similar issue as tonic relies on the crates.io release of tracing.

This looks good, still waiting on an admin to fix the builds or rust nightly to ship with rustfmt.

@jtescher jtescher merged commit c823385 into open-telemetry:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants