Skip to content

The probability sampler should ignore the parent sampled flag #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2020
Merged

The probability sampler should ignore the parent sampled flag #154

merged 1 commit into from
Jul 23, 2020
+5 −5

Conversation

@craigpastro
Copy link
Contributor

@craigpastro craigpastro commented Jul 23, 2020 •
edited
Loading

Closes #150.

Locally cargo fmt is hitting a number of files that seem to need it. I didn't push a commit but I could if you would like.

@craigpastro craigpastro requested a review from a team July 23, 2020 02:20
jtescher
jtescher approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks @siyopao

@jtescher jtescher merged commit a5523ae into open-telemetry:master Jul 23, 2020
@craigpastro craigpastro deleted the ignore-parent-sampled-flag branch July 23, 2020 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jtescher jtescher jtescher approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Probability sampler should ignore the parent sampled flag

2 participants

@craigpastro @jtescher