Skip to content

Conversation

@utpilla
Copy link
Contributor

@utpilla utpilla commented Sep 4, 2024

Changes

  • Add benchmarks for two specific use cases:
    • Create attributes of value types other than static string slices
    • Create attributes of value types other than strings

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@utpilla utpilla requested a review from a team September 4, 2024 19:35
@codecov
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.9%. Comparing base (54a3ad1) to head (28ef108).
Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2080   +/-   ##
=====================================
  Coverage   77.9%   77.9%           
=====================================
  Files        121     121           
  Lines      21143   21143           
=====================================
  Hits       16478   16478           
  Misses      4665    4665           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit 4a86e16 into open-telemetry:main Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants