Skip to content

Conversation

@scottgerring
Copy link
Member

Fixes #
Follow on from #3126

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@scottgerring scottgerring requested a review from a team as a code owner October 21, 2025 06:06
@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.8%. Comparing base (796ac1a) to head (c27ef5e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-otlp/src/retry.rs 62.5% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #3204     +/-   ##
=======================================
- Coverage   80.8%   80.8%   -0.1%     
=======================================
  Files        129     129             
  Lines      23199   23203      +4     
=======================================
+ Hits       18749   18750      +1     
- Misses      4450    4453      +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scottgerring scottgerring force-pushed the chore/otlp-retry-postreview-cleanup branch from aaa5214 to 16d0863 Compare October 21, 2025 06:15
@scottgerring
Copy link
Member Author

scottgerring commented Oct 21, 2025

Open for suggestions for where we can put the runtime selection. This strikes me as a broader question about the stabilisation of the runtime mechanism.

https://github.com/scottgerring/opentelemetry-rust/blob/9ba3a06df952d4888009764bebe665281f9e45b7/opentelemetry-otlp/src/exporter/http/mod.rs#L402-L409

@scottgerring scottgerring force-pushed the chore/otlp-retry-postreview-cleanup branch from 483c4de to e7c40bd Compare October 31, 2025 07:45
@scottgerring
Copy link
Member Author

@cijothomas the build failure split out here has nothing to do with this change:
#3216

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM- left a comment on lowering severity for retry attempts.

@scottgerring
Copy link
Member Author

@cijothomas pushed log level change

@cijothomas cijothomas merged commit df412fe into open-telemetry:main Nov 19, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants