Automated GitHub Action to Prevent PRs from Main Branch#6440
Automated GitHub Action to Prevent PRs from Main Branch#6440shalini-saloni wants to merge 3 commits intoopen-telemetry:mainfrom
Conversation
| steps: | ||
| - name: Fail if PR is from 'main' branch | ||
| run: | | ||
| if [[ "${{ github.head_ref }}" == "main" ]]; then |
There was a problem hiding this comment.
I'm not a security expert, but I think there may be a risk of template injection here.
github.head_ref is user-controllable input IIUC. I can't come up with something that would do harm right of the bat, but I can break the workflow by using a branch name like foo";hostname
Might be safer to have it be put in an env variable (outside of run) as to not influence script generation.
svrnm
left a comment
svrnm
left a comment
There was a problem hiding this comment.
While it is best practice indeed to not use the main branch for PRs, I am not worried that much about it:
If a PR is created from main, maintainers can't easily make edits or use automated /fix commands.
That's not correct. the edits are allowed and I can run fix commands, this is only problematic if the PR comes from an ORG and not a USER. (This PR itself is from your main branch and I can see that github allows me to edit it)
It can cause conflicts if multiple PRs are based on the same main branch.
True, but that's then the problem of the contributor to figure out :-)
It can lead to issues when merging, since main is usually the production or stable branch.
That statement makes no sense. If someone forks our repo and creates a PR from their main branch, nothing of that is production/stable.
While I appreciate your time and effort, I don't think adding this workflow is worth the maintanance it will add to the repo
|
Closing old PR |
4 participants
Problem: Sometimes, contributors accidentally submit PRs from the main branch instead of a separate branch.
Why is this a problem?
If a PR is created from main, maintainers can't easily make edits or use automated /fix commands.
It can cause conflicts if multiple PRs are based on the same main branch.
It can lead to issues when merging, since main is usually the production or stable branch.
Proposed Solution:
I implemented a GitHub Actions check that automatically fails a PR if it originates from the main branch. This ensures contributors receive an immediate warning, preventing maintainers from discovering the issue later in the review process. 🚀