bluetooth: add zblue settings save & load implement. #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuX10
force-pushed
the
local_dev
branch
2 times, most recently
from
2dc49c3 to
f47ee52
Compare
This was referenced Dec 10, 2025
liuX10
force-pushed
the
local_dev
branch
3 times, most recently
from
e74fbe3 to
0b63774
Compare
chengkai15
reviewed
Dec 10, 2025
chengkai15
reviewed
Dec 10, 2025
liuX10
force-pushed
the
local_dev
branch
2 times, most recently
from
b445800 to
71af02b
Compare
gzh-terry
reviewed
Dec 10, 2025
gzh-terry
reviewed
Dec 10, 2025
liuX10
force-pushed
the
local_dev
branch
5 times, most recently
from
557bf4a to
c0821ac
Compare
liuX10
force-pushed
the
local_dev
branch
4 times, most recently
from
7c73e06 to
7cc5aeb
Compare
Contributor
Contributor
Contributor
|
CI failure. |
gzh-terry
reviewed
Dec 13, 2025
gzh-terry
reviewed
Dec 13, 2025
gzh-terry
reviewed
Dec 13, 2025
gzh-terry
reviewed
Dec 13, 2025
gzh-terry
reviewed
Dec 13, 2025
gzh-terry
reviewed
Dec 13, 2025
gzh-terry
approved these changes
Dec 13, 2025
Contributor
gzh-terry
left a comment
gzh-terry
left a comment
There was a problem hiding this comment.
There is a few comments, but generally looks good to me.
liuX10
force-pushed
the
local_dev
branch
2 times, most recently
from
fcbc538 to
9402767
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated 11 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bug: v/79394 Implement the SAL layer callback function for settings storage. include: 1. SAL zblue_on_ltk_notify & zblue_on_ltk_load 2. add adapter_get_smp_data API 3. add adapter_get_local_csrk API Signed-off-by: liuxiang18 <liuxiang18@xiaomi.com>
bug: v/79394 Implement the SAL layer callback function for settings storage. include: 1. SAL zblue_on_linkkey_notify & zblue_on_linkkey_load 2. add adapter_get_link_key API 3. add adapter_get_link_key_type API Signed-off-by: liuxiang18 <liuxiang18@xiaomi.com>
bug: v/79393
Implement the SAL layer callback function for settings storage.
include:
BLE: zblue_on_irk_notify
zblue_on_irk_load
Signed-off-by: liuxiang18 <liuxiang18@xiaomi.com>
bug: v/79395 1. adaptInfo add 'irk', and remote_device_le_properties_t add 'local_csrk'. 2. change storage version number to v5_0_3 3. add v5_0_2->v5_0_3 storage update function Signed-off-by: liuxiang18 <liuxiang18@xiaomi.com>
bug: v/73508 ARRAY_SIZE() is defined at "bt_utils.h" Signed-off-by: liuxiang18 <liuxiang18@xiaomi.com>
bug: v/79394 bt_unpair invokes the unpair function, where the bond_delete callback occurs before keys_clear. keys_clear sets memset(&keys->addr, 0, sizeof(bt_addr_le_t)), causing the bond_delete callback to reference an empty address. Signed-off-by: liuxiang18 <liuxiang18@xiaomi.com>
zhongzhijie1
approved these changes
Dec 14, 2025
hyson710
approved these changes
Dec 14, 2025
hyson710
approved these changes
Dec 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends-on: [open-vela/external_zblue/pull/119 open-vela/external/pull/40 open-vela/vendor_openvela/pull/33]