Skip to content

improve oracle benchmarks #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2025
Merged

improve oracle benchmarks #1036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions oracle/src/benchmarking.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
use super::*;
use crate::Pallet as Oracle;
pub use crate::*;

use frame_benchmarking::v2::*;
use frame_benchmarking::v2::{impl_test_function, instance_benchmarks, whitelisted_caller};

use frame_support::assert_ok;
use frame_system::{Pallet as System, RawOrigin};
Expand Down Expand Up @@ -36,18 +35,18 @@ mod benchmarks {
// Feed some values before running `on_finalize` hook
System::<T>::set_block_number(1u32.into());
let values = T::BenchmarkHelper::get_currency_id_value_pairs();
assert_ok!(Oracle::<T, I>::feed_values(RawOrigin::Signed(caller).into(), values));
assert_ok!(Pallet::<T, I>::feed_values(RawOrigin::Signed(caller).into(), values));

#[block]
{
Oracle::<T, I>::on_finalize(System::<T>::block_number());
Pallet::<T, I>::on_finalize(System::<T>::block_number());
}

assert!(!HasDispatched::<T, I>::exists());
}

impl_benchmark_test_suite! {
Oracle,
Pallet,
crate::mock::new_test_ext(),
crate::mock::Test,
}
Expand Down
2 changes: 1 addition & 1 deletion oracle/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ use sp_std::{prelude::*, vec};
pub use crate::default_combine_data::DefaultCombineData;

#[cfg(feature = "runtime-benchmarks")]
mod benchmarking;
pub mod benchmarking;

mod default_combine_data;
mod mock;
Expand Down