Skip to content

[WIP] Add missing subtype field to Creature model#940

Draft
Copilot wants to merge 1 commit into
stagingfrom
copilot/add-subtype-field-creature-model
Draft

[WIP] Add missing subtype field to Creature model#940
Copilot wants to merge 1 commit into
stagingfrom
copilot/add-subtype-field-creature-model

Conversation

Copy link
Copy Markdown

Copilot AI commented May 31, 2026

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.


This section details on the original issue you should resolve

<issue_title>[BUG] Add missing subtype field to Creature model</issue_title>
<issue_description>## Bug description
Many creatures in the O5e dataset contain a creature subtype in their document sources. Take the example of the Merfolk flagged in issue #923

Compare its entry in the WotC SRD 5.1 (pp. 332)
Image

To the representation on the Open5e site (https://open5e.com/monsters/srd_merfolk)

Image

Notice that the Creature's subtype in the source document (the merfolk in parenthesis underneath the creature's name) is not included in the API response. Looking into the Creature model and things are a little confusing:

  "key": "srd_merfolk",
   "name": "Merfolk",
   "document": {
       "name": "System Reference Document 5.1",
       "key": "srd-2014",
        ...
   },
   "type": {
       "name": "Humanoid",
       "key": "humanoid"
   },
  "category": "Monsters",
   "subcategory": null,

There seems to be some muddiness of terms here: type (a FK to the CreatureType model) represents a creatures type (ie. humanoid, aberration) while category intended to be the list it is included in the source document. ie. in the srd-2014 there are Monster, Miscellaneous Creatures and Nonplayer Characters lists. subcategory seems to convey how certain statblocks are grouped together in certain documents (ie. skeletons in SRD 2014:

Image

A field to include subtype information appears to be absent from the Creature model, best I can tell. The addition of a subtype field is probably called for to support the resolution of this issue.</issue_description>

Comments on the Issue (you are @copilot in this section)

Copilot AI linked an issue May 31, 2026 that may be closed by this pull request
Copilot stopped work on behalf of eepMoody due to an error May 31, 2026 00:41
Copilot AI requested a review from eepMoody May 31, 2026 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Add missing subtype field to Creature model

2 participants